You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/24 09:34:19 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #28916: [SPARK-32083][SQL] Coalesce to one partition when all partitions are empty in AQE
cloud-fan commented on a change in pull request #28916:
URL: https://github.com/apache/spark/pull/28916#discussion_r444768751
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/ShufflePartitionsUtil.scala
##########
@@ -92,9 +92,10 @@ object ShufflePartitionsUtil extends Logging {
var coalescedSize = 0L
var i = 0
- def createPartitionSpec(): Unit = {
- // Skip empty inputs, as it is a waste to launch an empty task.
- if (coalescedSize > 0) {
+ def createPartitionSpec(last: Boolean = false): Unit = {
+ // Skip empty inputs, as it is a waste to launch an empty task
+ // unless all inputs are empty
+ if (coalescedSize > 0 || (last && partitionSpecs.isEmpty)) {
Review comment:
so you want to create at lease one partition? This doesn't match the PR description.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/ShufflePartitionsUtil.scala
##########
@@ -92,9 +92,10 @@ object ShufflePartitionsUtil extends Logging {
var coalescedSize = 0L
var i = 0
- def createPartitionSpec(): Unit = {
- // Skip empty inputs, as it is a waste to launch an empty task.
- if (coalescedSize > 0) {
+ def createPartitionSpec(last: Boolean = false): Unit = {
+ // Skip empty inputs, as it is a waste to launch an empty task
+ // unless all inputs are empty
+ if (coalescedSize > 0 || (last && partitionSpecs.isEmpty)) {
Review comment:
so you want to create at least one partition? This doesn't match the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org