You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "alexey-milovidov (via GitHub)" <gi...@apache.org> on 2024/05/15 22:57:40 UTC
[PR] Fix UBSan report while compiling with clang-18 [datasketches-cpp]
alexey-milovidov opened a new pull request, #432:
URL: https://github.com/apache/datasketches-cpp/pull/432
This is a benign report. But clang-18 started to complain.
See https://github.com/ClickHouse/ClickHouse/issues/63858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Fix UBSan report while compiling with clang-18 [datasketches-cpp]
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on PR #432:
URL: https://github.com/apache/datasketches-cpp/pull/432#issuecomment-2115884634
This makes sense. I don't think the existing code is unsafe, but UBSan has trouble determining that and (validly) complains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Fix UBSan report while compiling with clang-18 [datasketches-cpp]
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin merged PR #432:
URL: https://github.com/apache/datasketches-cpp/pull/432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Fix UBSan report while compiling with clang-18 [datasketches-cpp]
Posted by "coveralls (via GitHub)" <gi...@apache.org>.
coveralls commented on PR #432:
URL: https://github.com/apache/datasketches-cpp/pull/432#issuecomment-2113705534
## Pull Request Test Coverage Report for [Build 9103733837](https://coveralls.io/builds/67518255)
### Details
* **1** of **1** **(100.0%)** changed or added relevant line in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **98.964%**
---
| Totals | [](https://coveralls.io/builds/67518255) |
| :-- | --: |
| Change from base [Build 9038987381](https://coveralls.io/builds/67431556): | 0.0% |
| Covered Lines: | 16427 |
| Relevant Lines: | 16599 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org