You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/06/01 08:17:18 UTC
[Bug 5492] New: VBounce rule not firing
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
Summary: VBounce rule not firing
Product: Spamassassin
Version: 3.2.0
Platform: Other
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Rules
AssignedTo: dev@spamassassin.apache.org
ReportedBy: Bob@mortimer.nildram.co.uk
VBounce isn't firing for me in 3.2.0. It was working fine as an additional
ruleset under previous versions.
I run spamassassin via amavisd-new 2.5.0 but have run messages through
spamassassin direct via commandline with the same result.
I tried commenting out my whitelist_bounce_relays lines in local.cf and ran a
genuine bounce through and it still didn't fire.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] VBounce rule not firing
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
------- Additional Comments From jm@jmason.org 2007-06-01 04:51 -------
you didn't say what you had "whitelist_bounce_relays" set to, so I guessed from
that genuine mail, and set to:
whitelist_bounce_relays linux.mortimer.nildram.co.uk smtp.nildram.co.uk
anyway, it looks like a bug alright. fix to follow...
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From sidney@sidney.com 2007-06-04 22:34 -------
Committed to branch 3.2 revision 544388.
It had already been committed to trunk.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|VBounce rule not firing |[review] VBounce rule not
| |firing: all bounces
| |whitelisted
Status Whiteboard| |2 votes needed for 3.2.1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
------- Additional Comments From Mark.Martinec@ijs.si 2007-09-13 05:25 -------
> Committed revision 575252.
> please vote for 3.2.x...
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
------- Additional Comments From jm@jmason.org 2007-08-28 02:25 -------
does that change fix your bug?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|2 votes needed for 3.2.1 |1 vote needed for 3.2.1
------- Additional Comments From spamassassin@dostech.ca 2007-06-01 14:44 -------
+1 on 3958+3961
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
Mark.Martinec@ijs.si changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes for 3.2 |needs 1 vote for 3.2
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
------- Additional Comments From hege@hege.li 2007-08-27 22:33 -------
Why are you calling get_pristine() and skipping headers, when a simple
get_pristine_body() call handles it? :-)
--- VBounce.pm.orig Wed Aug 8 16:19:14 2007
+++ VBounce.pm Tue Aug 28 08:30:13 2007
@@ -115,16 +115,7 @@
# don't use the more efficient find_parts() method until bug 5331 is
# fixed, otherwise we'll miss some messages due to their MIME structure
- my $pristine = $pms->{msg}->get_pristine();
- # skip past the headers
- my $foundnlnl = 0;
- foreach my $line ($pristine =~ /^(.*)$/gm) {
- # note: do not use any re match here, it'll reset /g
- if ($line eq "" || $line eq "\012" || $line eq "\015\012") {
- $foundnlnl = 1; last;
- }
- }
- return 0 unless $foundnlnl;
+ my $pristine = $pms->{msg}->get_pristine_body();
# and now through the pristine body
foreach my $line ($pristine =~ /^(.*)$/gm) {
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
Status Whiteboard|can be commited |needs 2 votes for 3.2
------- Additional Comments From jm@jmason.org 2007-09-13 03:42 -------
ok, applied to trunk:
: jm 99...; svn commit -m "bug 5492: use get_pristine_body() API instead of more
complex get_pristine() usage, thanks to Henrik Krohns"
lib/Mail/SpamAssassin/Plugin/VBounce.pm
Sending lib/Mail/SpamAssassin/Plugin/VBounce.pm
Transmitting file data .
Committed revision 575252.
please vote for 3.2.x...
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
------- Additional Comments From hege@hege.li 2007-08-28 04:16 -------
Yes it works fine.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] VBounce rule not firing
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
------- Additional Comments From Bob@mortimer.nildram.co.uk 2007-05-31 23:26 -------
Created an attachment (id=3956)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3956&action=view)
Joe job bounce email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
------- Additional Comments From hege@hege.li 2007-08-26 14:55 -------
I'm sorry to say the fix doesn't work here. I'm using self compiled Perl 5.8.8
on Solaris 9 Sparc, SA 3.2.3.
A simple test message:
==============================
Return-Path: <>
Received: from smtp.inside.net ([127.0.0.1])
Received: from smtp.outside.net ([1.2.3.4])
Message-ID: <as...@foobar>
This multi-part MIME message contains a Delivery Status Notification.
Received: from smtp.outside.net ([1.2.3.4])
==============================
Debug output:
[21446] dbg: rules: relay smtp.outside.net doesn't match any whitelist
[21446] dbg: rules: relay smtp.inside.net doesn't match any whitelist
[21446] dbg: rules: relay smtp.outside.net doesn't match any whitelist
[21446] dbg: rules: relay smtp.outside.net doesn't match any whitelist
As you see, the regexp is still reseted, always matching
"whitelist_bounce_relays smtp.inside.net".
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.2.1 |3.2.4
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] VBounce rule not firing
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
------- Additional Comments From Bob@mortimer.nildram.co.uk 2007-05-31 23:37 -------
Created an attachment (id=3957)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3957&action=view)
A genuine undeliverable mail
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
guenther@rudersport.de changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |guenther@rudersport.de
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] VBounce rule not firing
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
------- Additional Comments From jm@jmason.org 2007-06-01 04:52 -------
Created an attachment (id=3958)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3958&action=view)
fix
This fixes the bug; basically, the use of a /^$/ match reset the m//g iterator,
so instead of looking through the message body for relays to check in
whitelist_bounce_relays, it instead looked through the header -- which always
contained whitelisted relays.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] VBounce rule not firing
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.2.1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
------- Additional Comments From spamassassin@dostech.ca 2007-06-01 11:22 -------
Should "\r\n" be "\013\010" instead?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3958 is|0 |1
obsolete| |
Attachment #3961 is|0 |1
obsolete| |
------- Additional Comments From jm@jmason.org 2007-09-13 03:42 -------
Created an attachment (id=4122)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4122&action=view)
as patch for 3.2.x
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
maddoc@maddoc.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|1 vote needed for 3.2.1 |can be commited
------- Additional Comments From maddoc@maddoc.net 2007-06-01 15:31 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
maddoc@maddoc.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote for 3.2 |can be commited
------- Additional Comments From maddoc@maddoc.net 2007-10-18 05:49 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
------- Additional Comments From jm@jmason.org 2007-06-01 12:44 -------
Created an attachment (id=3961)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3961&action=view)
fix part 2
yeah, good point; it's just defensive anyway ;) here's an additional
patch (on top of 3958).
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5492] [review] VBounce rule not firing: all bounces whitelisted
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5492
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
------- Additional Comments From jm@jmason.org 2007-10-18 08:36 -------
thanks guys, applied as of 586008.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.