You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/24 17:24:40 UTC
[GitHub] [flink] bowenli86 edited a comment on issue #8222: [FLINK-11518]
[table] Add partition related catalog APIs and implement them in
GenericInMemoryCatalog
bowenli86 edited a comment on issue #8222: [FLINK-11518] [table] Add partition related catalog APIs and implement them in GenericInMemoryCatalog
URL: https://github.com/apache/flink/pull/8222#issuecomment-486341814
Thanks for your reivew @JingsongLi @wuchong @xuefuz. To summarize major feedbacks I've addressed:
- make CatalogPartitionSpec its own class, and use it as id for partitions in APIs, like ObjectPath as id for tables
- removed its copy() method, since it internally keeps an unmodifiable map
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services