You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2016/06/29 23:53:13 UTC

Review Request 49408: HIVE-13945 Decimal value is displayed as rounded when selecting where clause with that decimal value.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49408/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  contrib/src/test/queries/clientpositive/udf_example_format.q 38069dc 
  contrib/src/test/results/clientpositive/udf_example_format.q.out 34b10c4 
  orc/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java 9e5f5cc 
  orc/src/java/org/apache/orc/impl/RecordReaderImpl.java 36a802e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java e154d13 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 9de1833 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToLong.java 045f0ab 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 227a051 
  ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java 1fa94b9 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java 6952ffb 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java 2e1384a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 5b32f56 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 67d8b86 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g a1909a7 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java a9e503d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 20d9649 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 239cc61 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java fc6540e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 3d85abd 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 24533d6 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java 795013a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java 351b593 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java 89e69be 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java e52e431 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java b89c14e 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 6fa3b3f 
  ql/src/test/queries/clientnegative/compare_double_bigint.q 8ee4b27 
  ql/src/test/queries/clientpositive/decimal_divide.q PRE-CREATION 
  ql/src/test/queries/clientpositive/implicit_decimal.q PRE-CREATION 
  ql/src/test/queries/clientpositive/input_lazyserde.q 74d7a2a 
  ql/src/test/queries/clientpositive/udf_java_method.q c0598cd 
  ql/src/test/queries/clientpositive/udf_reflect.q 97fa817 
  ql/src/test/queries/clientpositive/vector_struct_in.q 0e3a4ca 
  ql/src/test/results/clientnegative/no_matching_udf.q.out cd3e72d 
  ql/src/test/results/clientnegative/udf_add_months_error_2.q.out 897f4f2 
  ql/src/test/results/clientnegative/udf_format_number_wrong4.q.out 6eca7f8 
  ql/src/test/results/clientnegative/udf_format_number_wrong5.q.out 6d7a3c1 
  ql/src/test/results/clientnegative/udf_trunc_error2.q.out 7d089fd 
  ql/src/test/results/clientnegative/wrong_column_type.q.out be48c4e 
  ql/src/test/results/clientpositive/annotate_stats_select.q.out a03040a 
  ql/src/test/results/clientpositive/cast1.q.out d87c04c 
  ql/src/test/results/clientpositive/decimal_6.q.out 2c2c97a 
  ql/src/test/results/clientpositive/decimal_divide.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/decimal_precision.q.out fa26248 
  ql/src/test/results/clientpositive/decimal_udf.q.out dad8663 
  ql/src/test/results/clientpositive/implicit_decimal.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/index_auto_partitioned.q.out f556369 
  ql/src/test/results/clientpositive/infer_const_type.q.out 4ff8c87 
  ql/src/test/results/clientpositive/input49.q.out 2d51528 
  ql/src/test/results/clientpositive/input_lazyserde.q.out 3cf3bd2 
  ql/src/test/results/clientpositive/lineage3.q.out 12ae13e 
  ql/src/test/results/clientpositive/list_bucket_dml_13.q.out 93ebef0 
  ql/src/test/results/clientpositive/literal_double.q.out 5d46d2d 
  ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out 39438e9 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out 82f5b12 
  ql/src/test/results/clientpositive/metadata_only_queries.q.out 9bbc9b9 
  ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 38321e9 
  ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out a9d03fc 
  ql/src/test/results/clientpositive/perf/query13.q.out c9167e7 
  ql/src/test/results/clientpositive/perf/query32.q.out b8c1468 
  ql/src/test/results/clientpositive/perf/query48.q.out 6473ad8 
  ql/src/test/results/clientpositive/perf/query58.q.out b688f5a 
  ql/src/test/results/clientpositive/perf/query65.q.out 6a6777b 
  ql/src/test/results/clientpositive/perf/query75.q.out bc1d4ea 
  ql/src/test/results/clientpositive/perf/query85.q.out 29cddf0 
  ql/src/test/results/clientpositive/perf/query89.q.out c80f06c 
  ql/src/test/results/clientpositive/spark/metadata_only_queries.q.out ff12260 
  ql/src/test/results/clientpositive/spark/vector_between_in.q.out d20aefd 
  ql/src/test/results/clientpositive/spark/vectorization_0.q.out bd3939e 
  ql/src/test/results/clientpositive/spark/vectorization_1.q.out 1b2d0e2 
  ql/src/test/results/clientpositive/spark/vectorization_12.q.out 2baa1df 
  ql/src/test/results/clientpositive/spark/vectorization_13.q.out 395cbd7 
  ql/src/test/results/clientpositive/spark/vectorization_14.q.out bd6e5ab 
  ql/src/test/results/clientpositive/spark/vectorization_15.q.out f157c51 
  ql/src/test/results/clientpositive/spark/vectorization_16.q.out 6a9383d 
  ql/src/test/results/clientpositive/spark/vectorization_17.q.out 799b19f 
  ql/src/test/results/clientpositive/spark/vectorization_3.q.out a9aba5f 
  ql/src/test/results/clientpositive/spark/vectorization_9.q.out 6a9383d 
  ql/src/test/results/clientpositive/spark/vectorization_div0.q.out a9d02b8 
  ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out 55ec10d 
  ql/src/test/results/clientpositive/spark/vectorized_math_funcs.q.out 444b9e0 
  ql/src/test/results/clientpositive/tez/explainuser_1.q.out d4b29c6 
  ql/src/test/results/clientpositive/tez/metadata_only_queries.q.out ad740c8 
  ql/src/test/results/clientpositive/tez/orc_ppd_basic.q.out 2d0984b 
  ql/src/test/results/clientpositive/tez/vector_between_in.q.out dd9ca84 
  ql/src/test/results/clientpositive/tez/vector_decimal_6.q.out 15c9757 
  ql/src/test/results/clientpositive/tez/vector_decimal_expressions.q.out e5e5b4b 
  ql/src/test/results/clientpositive/tez/vector_decimal_math_funcs.q.out cf9a71e 
  ql/src/test/results/clientpositive/tez/vector_decimal_precision.q.out 5524a21 
  ql/src/test/results/clientpositive/tez/vector_decimal_udf.q.out bcf1ab6 
  ql/src/test/results/clientpositive/tez/vector_struct_in.q.out 1d75d04 
  ql/src/test/results/clientpositive/tez/vectorization_0.q.out 18b43f6 
  ql/src/test/results/clientpositive/tez/vectorization_1.q.out 1b2d0e2 
  ql/src/test/results/clientpositive/tez/vectorization_12.q.out 2baa1df 
  ql/src/test/results/clientpositive/tez/vectorization_13.q.out d5cc966 
  ql/src/test/results/clientpositive/tez/vectorization_14.q.out 8b9d98f 
  ql/src/test/results/clientpositive/tez/vectorization_15.q.out 70ab845 
  ql/src/test/results/clientpositive/tez/vectorization_16.q.out dd04469 
  ql/src/test/results/clientpositive/tez/vectorization_17.q.out e812592 
  ql/src/test/results/clientpositive/tez/vectorization_3.q.out a9aba5f 
  ql/src/test/results/clientpositive/tez/vectorization_8.q.out 1b51eb6 
  ql/src/test/results/clientpositive/tez/vectorization_9.q.out dd04469 
  ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 7ad9ab6 
  ql/src/test/results/clientpositive/tez/vectorization_short_regress.q.out 85fc577 
  ql/src/test/results/clientpositive/tez/vectorized_math_funcs.q.out 444b9e0 
  ql/src/test/results/clientpositive/udf4.q.out 9751168 
  ql/src/test/results/clientpositive/udf6.q.out 0b92bd5 
  ql/src/test/results/clientpositive/udf_abs.q.out d756185 
  ql/src/test/results/clientpositive/udf_bround.q.out 4dcea6d 
  ql/src/test/results/clientpositive/udf_case.q.out 05c65c9 
  ql/src/test/results/clientpositive/udf_coalesce.q.out 83024f2 
  ql/src/test/results/clientpositive/udf_format_number.q.out 1fa4d5c 
  ql/src/test/results/clientpositive/udf_if.q.out fe41924 
  ql/src/test/results/clientpositive/udf_java_method.q.out 2c66a8f 
  ql/src/test/results/clientpositive/udf_least.q.out 497370e 
  ql/src/test/results/clientpositive/udf_reflect.q.out 4c31977 
  ql/src/test/results/clientpositive/udf_round.q.out f0a8e7a 
  ql/src/test/results/clientpositive/udf_round_3.q.out 7bc7ca5 
  ql/src/test/results/clientpositive/udf_sort_array.q.out a29763a 
  ql/src/test/results/clientpositive/udf_union.q.out 114040f 
  ql/src/test/results/clientpositive/udf_when.q.out 3681908 
  ql/src/test/results/clientpositive/vector_between_in.q.out 0d55c9b 
  ql/src/test/results/clientpositive/vector_decimal_6.q.out 15c9757 
  ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 9244efd 
  ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out 0b70d4c 
  ql/src/test/results/clientpositive/vector_decimal_precision.q.out 805cb7a 
  ql/src/test/results/clientpositive/vector_decimal_udf.q.out b99fd10 
  ql/src/test/results/clientpositive/vector_struct_in.q.out b053f36 
  ql/src/test/results/clientpositive/vectorization_0.q.out b12ae68 
  ql/src/test/results/clientpositive/vectorization_1.q.out 1b2d0e2 
  ql/src/test/results/clientpositive/vectorization_12.q.out 2baa1df 
  ql/src/test/results/clientpositive/vectorization_13.q.out aa014a0 
  ql/src/test/results/clientpositive/vectorization_14.q.out d809808 
  ql/src/test/results/clientpositive/vectorization_15.q.out 700d230 
  ql/src/test/results/clientpositive/vectorization_16.q.out 5dcd2aa 
  ql/src/test/results/clientpositive/vectorization_17.q.out 294451e 
  ql/src/test/results/clientpositive/vectorization_3.q.out a9aba5f 
  ql/src/test/results/clientpositive/vectorization_8.q.out af515f5 
  ql/src/test/results/clientpositive/vectorization_9.q.out 5dcd2aa 
  ql/src/test/results/clientpositive/vectorization_div0.q.out 7d49358 
  ql/src/test/results/clientpositive/vectorization_short_regress.q.out 3098648 
  ql/src/test/results/clientpositive/vectorized_math_funcs.q.out 3a57d92 
  ql/src/test/results/clientpositive/view_cast.q.out 34444ae 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java 6415bf8 
  serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/DecimalTypeInfo.java d00f77d 
  storage-api/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 1c6be91 

Diff: https://reviews.apache.org/r/49408/diff/


Testing
-------


Thanks,

Sergey Shelukhin