You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/23 07:46:19 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5828: Show assigned cpu in dump task and other fix for qemu rv
no1wudi opened a new pull request #5828:
URL: https://github.com/apache/incubator-nuttx/pull/5828
## Summary
Show assigned cpu in dump task, before this PR:
```
[CPU0] riscv_showtasks: PID PRI USED STACK FILLED COMMAND
[CPU0] riscv_showtasks: ---- ---- 0 2048 0.0% irq
[CPU0] riscv_dump_task: 0 0 1056 2000 52.8% CPU0 IDLE
[CPU0] riscv_dump_task: 1 0 560 2000 28.0% CPU1 IDLE
[CPU0] riscv_dump_task: 2 0 560 2000 28.0% CPU2 IDLE
[CPU0] riscv_dump_task: 3 0 560 2000 28.0% CPU3 IDLE
[CPU0] riscv_dump_task: 4 0 32 2000 1.6% CPU4 IDLE
[CPU0] riscv_dump_task: 5 0 32 2000 1.6% CPU5 IDLE
[CPU0] riscv_dump_task: 6 0 32 2000 1.6% CPU6 IDLE
[CPU0] riscv_dump_task: 7 0 32 2000 1.6% CPU7 IDLE
```
after
```
[CPU0] riscv_showtasks: PID PRI CPU USED STACK FILLED COMMAND
[CPU0] riscv_showtasks: ---- ---- ---- 0 2048 0.0% irq
[CPU0] riscv_dump_task: 0 0 0 1056 2000 52.8% CPU0 IDLE
[CPU0] riscv_dump_task: 1 0 1 560 2000 28.0% CPU1 IDLE
[CPU0] riscv_dump_task: 2 0 2 560 2000 28.0% CPU2 IDLE
[CPU0] riscv_dump_task: 3 0 3 560 2000 28.0% CPU3 IDLE
[CPU0] riscv_dump_task: 4 0 4 32 2000 1.6% CPU4 IDLE
[CPU0] riscv_dump_task: 5 0 5 32 2000 1.6% CPU5 IDLE
[CPU0] riscv_dump_task: 6 0 6 32 2000 1.6% CPU6 IDLE
[CPU0] riscv_dump_task: 7 0 7 32 2000 1.6% CPU7 IDLE
```
## Impact
dumptask for risc-v only
## Testing
rv-virt with qemu 6.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5828: Show assigned cpu in dump task and other fix for qemu rv
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5828:
URL: https://github.com/apache/incubator-nuttx/pull/5828#discussion_r832952564
##########
File path: arch/risc-v/src/qemu-rv/qemu_rv_irq_dispatch.c
##########
@@ -117,6 +117,34 @@ void *riscv_dispatch_irq(uintptr_t vector, uintptr_t *regs)
}
#endif
+#if defined(CONFIG_ARCH_FPU) || defined(CONFIG_ARCH_ADDRENV)
Review comment:
split to the new PR
##########
File path: arch/risc-v/src/common/riscv_assert.c
##########
@@ -244,6 +250,9 @@ static inline void riscv_showtasks(void)
/* Dump interesting properties of each task in the crash environment */
_alert(" PID PRI"
+#ifdef CONFIG_SMP
+ " CPU"
Review comment:
let's update riscv/xtensa too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5828: Show assigned cpu in dump task
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5828:
URL: https://github.com/apache/incubator-nuttx/pull/5828#issuecomment-1076071227
Perfect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on pull request #5828: Show assigned cpu in dump task
Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5828:
URL: https://github.com/apache/incubator-nuttx/pull/5828#issuecomment-1076058553
> BTW how about ps from nsh?
output from ps:
```
NuttShell (NSH) NuttX-10.2.0
nsh> ps
PID GROUP CPU PRI POLICY TYPE NPX STATE EVENT SIGMASK STACK USED FILLED COMMAND
0 0 0 0 FIFO Kthread N-- Assigned 00000000 002000 000880 44.0% CPU0 IDLE
1 1 1 0 FIFO Kthread N-- Running 00000000 002000 000032 1.6% CPU1 IDLE
2 2 2 0 FIFO Kthread N-- Running 00000000 002000 000032 1.6% CPU2 IDLE
3 3 3 0 FIFO Kthread N-- Running 00000000 002000 000032 1.6% CPU3 IDLE
4 4 4 0 FIFO Kthread N-- Running 00000000 002000 000032 1.6% CPU4 IDLE
5 5 5 0 FIFO Kthread N-- Running 00000000 002000 000032 1.6% CPU5 IDLE
6 6 6 0 FIFO Kthread N-- Running 00000000 002000 000032 1.6% CPU6 IDLE
7 7 7 0 FIFO Kthread N-- Running 00000000 002000 000032 1.6% CPU7 IDLE
8 8 0 100 RR Task --- Running 00000000 004064 002080 51.1% nsh_main
nsh>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5828: Show assigned cpu in dump task
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5828:
URL: https://github.com/apache/incubator-nuttx/pull/5828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5828: Show assigned cpu in dump task
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5828:
URL: https://github.com/apache/incubator-nuttx/pull/5828#issuecomment-1076056638
BTW how about ps from nsh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org