You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/29 14:22:27 UTC
[GitHub] [rocketmq] PansonPanson opened a new pull request, #4532: [ISSUE #4513] elegant equals using apache-commons
PansonPanson opened a new pull request, #4532:
URL: https://github.com/apache/rocketmq/pull/4532
I'm reading the sourcecode of store module and there are some cpde snippets in class org.apache.rocketmq.store.DefaultMessageStore that I think need to be fixed.
- **code snippet 1**: redundant code and unreachable statement (`match` is always true)
<img width="1177" alt="Screen Shot 2022-06-29 at 21 34 38" src="https://user-images.githubusercontent.com/16064908/176451335-51e16363-081c-4077-9c1b-e5aa39c8287c.png">
- code snippet 2 : replacing with `enhanced for` to Improve code readability
<img width="1101" alt="image" src="https://user-images.githubusercontent.com/16064908/176458447-64fb2c6c-7570-4513-ade1-0c6174865704.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #4532: [ISSUE #4531] fix unreachable statement, redundant code and code style
Posted by GitBox <gi...@apache.org>.
duhenglucky merged PR #4532:
URL: https://github.com/apache/rocketmq/pull/4532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] PansonPanson commented on pull request #4532: [ISSUE #4531] elegant equals using apache-commons
Posted by GitBox <gi...@apache.org>.
PansonPanson commented on PR #4532:
URL: https://github.com/apache/rocketmq/pull/4532#issuecomment-1170051581
linked [issue : 4531](https://github.com/apache/rocketmq/issues/4531)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4532: [ISSUE #4531] fix unreachable statement, redundant code and code style
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4532:
URL: https://github.com/apache/rocketmq/pull/4532#issuecomment-1170732250
[](https://coveralls.io/builds/50487141)
Coverage increased (+0.01%) to 52.187% when pulling **15bbba3ba888c7b4038d5a96c9ac796c742750b3 on PansonPanson:develop** into **364494166daec2711455aa0768990997eb692d8e on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] guyinyou commented on pull request #4532: [ISSUE #4531] fix unreachable statement, redundant code and code style
Posted by GitBox <gi...@apache.org>.
guyinyou commented on PR #4532:
URL: https://github.com/apache/rocketmq/pull/4532#issuecomment-1171864586
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] PansonPanson commented on pull request #4532: [ISSUE #4531] fix unreachable statement, redundant code and code style
Posted by GitBox <gi...@apache.org>.
PansonPanson commented on PR #4532:
URL: https://github.com/apache/rocketmq/pull/4532#issuecomment-1171969966
> Pretty thoughtful change. I believe there are still a lot of similar issues in our code. Please could you help us improve them in the future? Really appreciate it.
sure, I’m going to read the source code in the next few months.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org