You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by normesta <gi...@git.apache.org> on 2016/04/01 01:46:01 UTC
[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...
GitHub user normesta opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161
New PR for Geo sample - sample link removed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/normesta/cordova-plugin-inappbrowser master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #161
----
commit bbf8345d705253c56b7ca5aafd9117219d686fef
Author: Norm Estabrook <no...@microsoft.com>
Date: 2016-03-31T22:00:59Z
adding a sample
commit f62576bab9e8a811abc397d95f0b8a11865061e6
Author: Norm Estabrook <no...@microsoft.com>
Date: 2016-03-31T23:45:24Z
removing sample link and including sample
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r58267690
--- Diff: README.md ---
@@ -394,3 +467,163 @@ Due to [MSDN docs](https://msdn.microsoft.com/en-us/library/windows.ui.xaml.cont
ref.addEventListener('loadstop', function() {
ref.insertCSS({file: "mystyles.css"});
});
+__
+
+## Sample: Show help pages with an InAppBrowser
+
+You can use this plugin to show helpful documentation pages within your app. Users can view online help documents and then close them without leaving the app.
+
+Here's a few snippets that show how you do this.
+
+* Give users a way to ask for help.
--- End diff --
Consider adding links to these options.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...
Posted by normesta <gi...@git.apache.org>.
Github user normesta commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r59801914
--- Diff: README.md ---
@@ -217,6 +217,79 @@ The object returned from a call to `cordova.InAppBrowser.open`.
- __callback__: the function that executes when the event fires. The function is passed an `InAppBrowserEvent` object as a parameter.
+## Example
+
+```javascript
+
+var inAppBrowserRef = undefined;
--- End diff --
Yep. I can do this by moving the other functions into the scope of the parent function
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r59835482
--- Diff: README.md ---
@@ -394,3 +467,163 @@ Due to [MSDN docs](https://msdn.microsoft.com/en-us/library/windows.ui.xaml.cont
ref.addEventListener('loadstop', function() {
ref.insertCSS({file: "mystyles.css"});
});
+__
+
+## Sample: Show help pages with an InAppBrowser
+
+You can use this plugin to show helpful documentation pages within your app. Users can view online help documents and then close them without leaving the app.
+
+Here's a few snippets that show how you do this.
+
+* Give users a way to ask for help.
--- End diff --
I meant make these hyperlinks to the sections below. Since the readme is long, these might be a good addition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161#issuecomment-210670012
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r58268931
--- Diff: README.md ---
@@ -217,6 +217,79 @@ The object returned from a call to `cordova.InAppBrowser.open`.
- __callback__: the function that executes when the event fires. The function is passed an `InAppBrowserEvent` object as a parameter.
+## Example
+
+```javascript
+
+var inAppBrowserRef = undefined;
--- End diff --
Can we pass this reference to the callbacks instead of defining it globally?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...
Posted by normesta <gi...@git.apache.org>.
Github user normesta commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r59802391
--- Diff: README.md ---
@@ -394,3 +467,163 @@ Due to [MSDN docs](https://msdn.microsoft.com/en-us/library/windows.ui.xaml.cont
ref.addEventListener('loadstop', function() {
ref.insertCSS({file: "mystyles.css"});
});
+__
+
+## Sample: Show help pages with an InAppBrowser
+
+You can use this plugin to show helpful documentation pages within your app. Users can view online help documents and then close them without leaving the app.
+
+Here's a few snippets that show how you do this.
+
+* Give users a way to ask for help.
--- End diff --
Not sure I understand this comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org