You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/20 11:22:18 UTC
[GitHub] [camel] Croway opened a new pull request #6567: CAMEL-17352: Add plain option
Croway opened a new pull request #6567:
URL: https://github.com/apache/camel/pull/6567
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #6567: CAMEL-17352: Add plain option
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #6567:
URL: https://github.com/apache/camel/pull/6567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #6567: CAMEL-17352: Add plain option
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #6567:
URL: https://github.com/apache/camel/pull/6567#discussion_r772474344
##########
File path: components/camel-log/src/main/java/org/apache/camel/component/log/LogEndpoint.java
##########
@@ -118,6 +118,8 @@
@UriParam(label = "formatting", enums = "Default,Tab,Fixed", defaultValue = "Default",
description = "Sets the outputs style to use.")
private DefaultExchangeFormatter.OutputStyle style = DefaultExchangeFormatter.OutputStyle.Default;
+ @UriParam(defaultValue = "false", description = "Log exchange body as-is (ex. log(\"${body}\").")
Review comment:
Lets use the same description:
```
If enabled only the body will be printed out
```
To make it stand out that all the other options are not considered then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6567: CAMEL-17352: Add plain option
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6567:
URL: https://github.com/apache/camel/pull/6567#issuecomment-997868399
You put tests inside core/camel-core for regular tests, and jmx tests in camel-management
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Croway commented on pull request #6567: CAMEL-17352: Add plain option
Posted by GitBox <gi...@apache.org>.
Croway commented on pull request #6567:
URL: https://github.com/apache/camel/pull/6567#issuecomment-997854024
Seems like camel-log cannot be tested due to cyclic references, like `org.apache.camel:camel-management:3.15.0-SNAPSHOT --> org.apache.camel:camel-log:3.15.0-SNAPSHOT --> org.apache.camel:camel-test-junit5:3.15.0-SNAPSHOT`, is there another way to test it? I'd like to use `CamelTestSupport` features like other components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Croway commented on pull request #6567: CAMEL-17352: Add plain option
Posted by GitBox <gi...@apache.org>.
Croway commented on pull request #6567:
URL: https://github.com/apache/camel/pull/6567#issuecomment-997883993
> You put tests inside core/camel-core for regular tests, and jmx tests in camel-management
I see, thanks for advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org