You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/25 07:48:29 UTC
[GitHub] [spark] LuciferYang opened a new pull request #35970: [MINOR] Remove Impossible `TODO` of Java style check
LuciferYang opened a new pull request #35970:
URL: https://github.com/apache/spark/pull/35970
### What changes were proposed in this pull request?
There are 2 TODOs in `checkstyle.xml`: `Indentation` and `ImportOrder`. Re enabling and fix them will involves hundreds of `Java` files, which not worth. So this pr delete these TODOs.
### Why are the changes needed?
Remove Impossible `TODO` of Java style check
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35970: [MINOR][BUILD] Remove `TODO` `Indentation|ImportOrder` module comments from Java `checkstyle.xml`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35970:
URL: https://github.com/apache/spark/pull/35970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35970: [MINOR] Remove Impossible `TODO` of Java style check
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35970:
URL: https://github.com/apache/spark/pull/35970#issuecomment-1078747421
As discussed in https://github.com/apache/spark/pull/35949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org