You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2023/05/21 01:25:10 UTC

[GitHub] [incubator-kvrocks-website] PragmaTwice commented on a diff in pull request #101: docs: update release doc

PragmaTwice commented on code in PR #101:
URL: https://github.com/apache/incubator-kvrocks-website/pull/101#discussion_r1199680528


##########
community/create-a-release.md:
##########
@@ -212,9 +212,10 @@ Docker and Docker Buildx is required for this step. Docker Buildx should be bund
 
 1. `docker login` to your own DockerHub account.
 2. Build and push docker images to your personal repository on DockerHub:
+3. MORE BUILD ARGS can be adjusted according to the performance of your computer
 
 ```shell
-docker buildx build --platform linux/amd64,linux/arm64 --tag ${your_dockerhub_username}/kvrocks:${release_version} --tag ${your_dockerhub_username}/kvrocks:latest . --output-type=registry
+docker buildx build --platform linux/amd64,linux/arm64 --tag ${your_dockerhub_username}/kvrocks:${release_version} --tag ${your_dockerhub_username}/kvrocks:latest . --output "type=registry" --build-arg MORE_BUILD_ARGS=-j12

Review Comment:
   What is the meaning of `12` here? Why is `12` fit for any CPU settings? We do not need these nonsense numbers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org