You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Peter Bacsko <pb...@cloudera.com> on 2017/09/28 11:25:06 UTC
Review Request 62660: OOZIE-3070 Remove references to
org.mortbay.jetty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62660/
-----------------------------------------------------------
Review request for oozie and András Piros.
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-3070
Diffs
-----
core/pom.xml b0809546d
core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java eeb7717c9
core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java 1f7e5b221
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6fcdf24bc
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4e4
pom.xml efccc3469
sharelib/hive2/pom.xml b74e51a34
sharelib/spark/pom.xml eb80439a4
Diff: https://reviews.apache.org/r/62660/diff/1/
Testing
-------
Thanks,
Peter Bacsko
Re: Review Request 62660: OOZIE-3070 Remove references to
org.mortbay.jetty
Posted by Peter Bacsko <pb...@cloudera.com>.
> On szept. 28, 2017, 12:49 du, Peter Cseh wrote:
> > core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java
> > Lines 1-6 (original), 1-6 (patched)
> > <https://reviews.apache.org/r/62660/diff/1/?file=1838936#file1838936line1>
> >
> > Can we move this class to src/test? We could then make the jetty-servlet a test-time dependency only.
Needed by LocalOozie, which is also under src/main. LocalOozie is referenced in oozie-examples.
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62660/#review186548
-----------------------------------------------------------
On szept. 28, 2017, 11:25 de, Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62660/
> -----------------------------------------------------------
>
> (Updated szept. 28, 2017, 11:25 de)
>
>
> Review request for oozie and András Piros.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-3070
>
>
> Diffs
> -----
>
> core/pom.xml b0809546d
> core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java eeb7717c9
> core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java 1f7e5b221
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6fcdf24bc
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4e4
> pom.xml efccc3469
> sharelib/hive2/pom.xml b74e51a34
> sharelib/spark/pom.xml eb80439a4
>
>
> Diff: https://reviews.apache.org/r/62660/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Bacsko
>
>
Re: Review Request 62660: OOZIE-3070 Remove references to
org.mortbay.jetty
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62660/#review186548
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java
Lines 1-6 (original), 1-6 (patched)
<https://reviews.apache.org/r/62660/#comment263108>
Can we move this class to src/test? We could then make the jetty-servlet a test-time dependency only.
- Peter Cseh
On Sept. 28, 2017, 11:25 a.m., Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62660/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 11:25 a.m.)
>
>
> Review request for oozie and András Piros.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-3070
>
>
> Diffs
> -----
>
> core/pom.xml b0809546d
> core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java eeb7717c9
> core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java 1f7e5b221
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6fcdf24bc
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4e4
> pom.xml efccc3469
> sharelib/hive2/pom.xml b74e51a34
> sharelib/spark/pom.xml eb80439a4
>
>
> Diff: https://reviews.apache.org/r/62660/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Bacsko
>
>
Re: Review Request 62660: OOZIE-3070 Remove references to
org.mortbay.jetty
Posted by Peter Cseh <ge...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62660/#review186550
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Cseh
On Sept. 28, 2017, 11:25 a.m., Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62660/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 11:25 a.m.)
>
>
> Review request for oozie and András Piros.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-3070
>
>
> Diffs
> -----
>
> core/pom.xml b0809546d
> core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java eeb7717c9
> core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java 1f7e5b221
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6fcdf24bc
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4e4
> pom.xml efccc3469
> sharelib/hive2/pom.xml b74e51a34
> sharelib/spark/pom.xml eb80439a4
>
>
> Diff: https://reviews.apache.org/r/62660/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Bacsko
>
>
Re: Review Request 62660: OOZIE-3070 Remove references to
org.mortbay.jetty
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62660/#review186551
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java
Lines 51-53 (patched)
<https://reviews.apache.org/r/62660/#comment263110>
If possible, I'm better off w/ a non-`static` solution.
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java
Lines 80 (patched)
<https://reviews.apache.org/r/62660/#comment263111>
If possible, I'm better off w/ a non-`static` solution.
- András Piros
On Sept. 28, 2017, 11:25 a.m., Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62660/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 11:25 a.m.)
>
>
> Review request for oozie and András Piros.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-3070
>
>
> Diffs
> -----
>
> core/pom.xml b0809546d
> core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java eeb7717c9
> core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java 1f7e5b221
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6fcdf24bc
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4e4
> pom.xml efccc3469
> sharelib/hive2/pom.xml b74e51a34
> sharelib/spark/pom.xml eb80439a4
>
>
> Diff: https://reviews.apache.org/r/62660/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Bacsko
>
>
Re: Review Request 62660: OOZIE-3070 Remove references to
org.mortbay.jetty
Posted by András Piros <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62660/#review186555
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On Sept. 28, 2017, 1:54 p.m., Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62660/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 1:54 p.m.)
>
>
> Review request for oozie and András Piros.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-3070
>
>
> Diffs
> -----
>
> core/pom.xml b0809546d
> core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java eeb7717c9
> core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java 1f7e5b221
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6fcdf24bc
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4e4
> pom.xml efccc3469
> sharelib/hive2/pom.xml b74e51a34
> sharelib/spark/pom.xml eb80439a4
>
>
> Diff: https://reviews.apache.org/r/62660/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Bacsko
>
>
Re: Review Request 62660: OOZIE-3070 Remove references to
org.mortbay.jetty
Posted by Peter Bacsko <pb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62660/
-----------------------------------------------------------
(Updated szept. 28, 2017, 1:54 du)
Review request for oozie and András Piros.
Changes
-------
Addressing comments
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-3070
Diffs (updated)
-----
core/pom.xml b0809546d
core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java eeb7717c9
core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java 1f7e5b221
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6fcdf24bc
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4e4
pom.xml efccc3469
sharelib/hive2/pom.xml b74e51a34
sharelib/spark/pom.xml eb80439a4
Diff: https://reviews.apache.org/r/62660/diff/2/
Changes: https://reviews.apache.org/r/62660/diff/1-2/
Testing
-------
Thanks,
Peter Bacsko
Re: Review Request 62660: OOZIE-3070 Remove references to
org.mortbay.jetty
Posted by Peter Bacsko <pb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62660/#review186543
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java
Lines 62-63 (original), 70-89 (patched)
<https://reviews.apache.org/r/62660/#comment263103>
There was a race condition in the test. Since the variables inside CallbackServlet are modified on a separate thread, the test failed randomly.
sharelib/hive2/pom.xml
Lines 47-50 (patched)
<https://reviews.apache.org/r/62660/#comment263104>
Note: I'm not sure we have to do this upstream, probably not - we definitely need to do this in CDH.
sharelib/spark/pom.xml
Lines 201-206 (patched)
<https://reviews.apache.org/r/62660/#comment263105>
Same as above
- Peter Bacsko
On szept. 28, 2017, 11:25 de, Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62660/
> -----------------------------------------------------------
>
> (Updated szept. 28, 2017, 11:25 de)
>
>
> Review request for oozie and András Piros.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-3070
>
>
> Diffs
> -----
>
> core/pom.xml b0809546d
> core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java eeb7717c9
> core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java 1f7e5b221
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6fcdf24bc
> core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4e4
> pom.xml efccc3469
> sharelib/hive2/pom.xml b74e51a34
> sharelib/spark/pom.xml eb80439a4
>
>
> Diff: https://reviews.apache.org/r/62660/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Bacsko
>
>