You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Korbinian Bachl <ko...@whiskyworld.de> on 2023/10/20 09:22:15 UTC

ModalWindow and wicket 10

Hi,

just a short question. Since wicket 10 removed ModalWindow and insists now on using ModalDialog even so many features of ModalWindow aren't in ModalDialog existing
(for example closeCallback, resize, move, header, closebutton, init of width, height etc.etc).

Would it maybe possible if the removal of ModalWindow gets postponed to wicket 11?

Problem is one can't use wicket 9 with jakarta (last lib that holds us back) and we have the ModalWindows over so many places with usages that arent really existing in ModalDialog anymore. 
(Or maybe a ModalWindow from WicketStuff?)

Best,

KB

Re: ModalWindow and wicket 10

Posted by Sven Meier <sv...@meiers.net>.
Hi Korbinian,

I won't have time to work on Wicket topics in the foreseeable future.

Sven


On 14.11.23 11:39, Korbinian Bachl wrote:
> My apologies for asking,
> did you have any time for having a look at it yet?
>
> If not, do you need any help with it?
>
> ----- Ursprüngliche Mail -----
>> Von: "Sven Meier"
>> An: "dev" <de...@wicket.apache.org>
>> Gesendet: Freitag, 20. Oktober 2023 12:16:53
>> Betreff: Re: ModalWindow and wicket 10
>> Hi,
>>
>> I thought we already moved the old implementation to wicket-stuff, but
>> apparently I forgot to do it actually.
>>
>> For explanation: the old ModalWindow is riddled with JS and dynamically
>> generated HTML markup which we didn't want to maintain any more.
>>
>> Sven
>>
>>
>> On 20.10.23 11:22, Korbinian Bachl wrote:
>>> Hi,
>>>
>>> just a short question. Since wicket 10 removed ModalWindow and insists now on
>>> using ModalDialog even so many features of ModalWindow aren't in ModalDialog
>>> existing
>>> (for example closeCallback, resize, move, header, closebutton, init of width,
>>> height etc.etc).
>>>
>>> Would it maybe possible if the removal of ModalWindow gets postponed to wicket
>>> 11?
>>>
>>> Problem is one can't use wicket 9 with jakarta (last lib that holds us back) and
>>> we have the ModalWindows over so many places with usages that arent really
>>> existing in ModalDialog anymore.
>>> (Or maybe a ModalWindow from WicketStuff?)
>>>
>>> Best,
>>>
>>> KB

Re: ModalWindow and wicket 10

Posted by Korbinian Bachl <ko...@whiskyworld.de>.
My apologies for asking, 
did you have any time for having a look at it yet?

If not, do you need any help with it?

----- Ursprüngliche Mail -----
> Von: "Sven Meier" 
> An: "dev" <de...@wicket.apache.org>
> Gesendet: Freitag, 20. Oktober 2023 12:16:53
> Betreff: Re: ModalWindow and wicket 10

> Hi,
> 
> I thought we already moved the old implementation to wicket-stuff, but
> apparently I forgot to do it actually.
> 
> For explanation: the old ModalWindow is riddled with JS and dynamically
> generated HTML markup which we didn't want to maintain any more.
> 
> Sven
> 
> 
> On 20.10.23 11:22, Korbinian Bachl wrote:
>> Hi,
>>
>> just a short question. Since wicket 10 removed ModalWindow and insists now on
>> using ModalDialog even so many features of ModalWindow aren't in ModalDialog
>> existing
>> (for example closeCallback, resize, move, header, closebutton, init of width,
>> height etc.etc).
>>
>> Would it maybe possible if the removal of ModalWindow gets postponed to wicket
>> 11?
>>
>> Problem is one can't use wicket 9 with jakarta (last lib that holds us back) and
>> we have the ModalWindows over so many places with usages that arent really
>> existing in ModalDialog anymore.
>> (Or maybe a ModalWindow from WicketStuff?)
>>
>> Best,
>>
> > KB

Re: ModalWindow and wicket 10

Posted by Korbinian Bachl <ko...@whiskyworld.de>.
wicket-stuff would be really nice :)


----- Ursprüngliche Mail -----
> Von: "Sven Meier" <sv...@meiers.net>
> An: "dev" <de...@wicket.apache.org>
> Gesendet: Freitag, 20. Oktober 2023 12:16:53
> Betreff: Re: ModalWindow and wicket 10

> Hi,
> 
> I thought we already moved the old implementation to wicket-stuff, but
> apparently I forgot to do it actually.
> 
> For explanation: the old ModalWindow is riddled with JS and dynamically
> generated HTML markup which we didn't want to maintain any more.
> 
> Sven
> 
> 
> On 20.10.23 11:22, Korbinian Bachl wrote:
>> Hi,
>>
>> just a short question. Since wicket 10 removed ModalWindow and insists now on
>> using ModalDialog even so many features of ModalWindow aren't in ModalDialog
>> existing
>> (for example closeCallback, resize, move, header, closebutton, init of width,
>> height etc.etc).
>>
>> Would it maybe possible if the removal of ModalWindow gets postponed to wicket
>> 11?
>>
>> Problem is one can't use wicket 9 with jakarta (last lib that holds us back) and
>> we have the ModalWindows over so many places with usages that arent really
>> existing in ModalDialog anymore.
>> (Or maybe a ModalWindow from WicketStuff?)
>>
>> Best,
>>
> > KB

Re: ModalWindow and wicket 10

Posted by Sven Meier <sv...@meiers.net>.
Hi,

I thought we already moved the old implementation to wicket-stuff, but 
apparently I forgot to do it actually.

For explanation: the old ModalWindow is riddled with JS and dynamically 
generated HTML markup which we didn't want to maintain any more.

Sven


On 20.10.23 11:22, Korbinian Bachl wrote:
> Hi,
>
> just a short question. Since wicket 10 removed ModalWindow and insists now on using ModalDialog even so many features of ModalWindow aren't in ModalDialog existing
> (for example closeCallback, resize, move, header, closebutton, init of width, height etc.etc).
>
> Would it maybe possible if the removal of ModalWindow gets postponed to wicket 11?
>
> Problem is one can't use wicket 9 with jakarta (last lib that holds us back) and we have the ModalWindows over so many places with usages that arent really existing in ModalDialog anymore.
> (Or maybe a ModalWindow from WicketStuff?)
>
> Best,
>
> KB