You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/05 15:55:01 UTC
[GitHub] [geode-native] pdxcodemonkey opened a new pull request, #952: Fix Ubuntu build break due to cmake upgrade
pdxcodemonkey opened a new pull request, #952:
URL: https://github.com/apache/geode-native/pull/952
- New cmake version changes treatment of CMAKE_INSTALL_LIBDIR variable,
which now evaluates to different things for xerces build and main
client build. As a result, we build Xerces, then go looking to link
to it in the wrong place. Hard-coding the path to just 'lib' for now
appears to fix the Ubuntu issue without breaking anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on a diff in pull request #952: Fix Ubuntu build break due to cmake upgrade
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on code in PR #952:
URL: https://github.com/apache/geode-native/pull/952#discussion_r843008777
##########
dependencies/xerces-c/CMakeLists.txt:
##########
@@ -64,7 +64,7 @@ target_include_directories(${PROJECT_NAME} SYSTEM INTERFACE
)
target_link_libraries(${PROJECT_NAME} INTERFACE
- ${INSTALL_DIR}/${CMAKE_INSTALL_LIBDIR}/${CMAKE_STATIC_LIBRARY_PREFIX}${LIBRARY_NAME}${CMAKE_STATIC_LIBRARY_SUFFIX}
+ ${INSTALL_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}${LIBRARY_NAME}${CMAKE_STATIC_LIBRARY_SUFFIX}
Review Comment:
As I feared, this breaks on RHEL.
I think the easiest work around right now is to have the CI set the `CMAKE_INSTALL_PREFIX` to something not `/usr` or `/usr/local` and leave this file alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey merged pull request #952: Fix Ubuntu build break due to cmake upgrade
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey merged PR #952:
URL: https://github.com/apache/geode-native/pull/952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org