You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Bence Szabó (Jira)" <ji...@apache.org> on 2021/04/23 11:45:00 UTC
[jira] [Commented] (SOLR-15067) Child doc transformer should use
the perSegFilter cache
[ https://issues.apache.org/jira/browse/SOLR-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330402#comment-17330402 ]
Bence Szabó commented on SOLR-15067:
------------------------------------
Hello [~dsmiley]
I would gladly implement the solution for this but I am yet a bit uncertain with the codebase, could you provide me with some help on this?
I think I have found the correct implementation here: [https://github.com/apache/solr/blob/67772018e1c81e9b238c5949d571a5195d1157a2/solr/core/src/java/org/apache/solr/search/join/BlockJoinParentQParser.java#L88-L97]
Also found the incorrect one in the ChildDocTransformerFactory, and understood the differences.
The first two questions that came to my mind is that in which package should this new class be found and how should other classes call/access its methods - like create a new instance at every call and call its method or a singleton like behaviour or something totally different?
Any other instructions or information are more than welcome.
Thanks, Bence
> Child doc transformer should use the perSegFilter cache
> -------------------------------------------------------
>
> Key: SOLR-15067
> URL: https://issues.apache.org/jira/browse/SOLR-15067
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Major
> Labels: newdev
>
> The ChildDocTransformerFactory creates a QueryBitSetProducer every time. These are heavy to compute; they should be cached. BlockJoinParentQParserPlugin does this correctly, using the "perSegFilter" named Solr cache. They should both do the same. To avoid duplication of logic, consider creating a new class named something like PerSegFilterCacheManager, or maybe manage directly on SolrIndexSearcher (alas; SIS is huge).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org