You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by da...@apache.org on 2013/06/21 10:14:23 UTC
svn commit: r1495317 - in
/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile:
ActivationClassBuilder.java CurrentRowLocationNode.java
ExpressionClassBuilder.java
Author: dag
Date: Fri Jun 21 08:14:22 2013
New Revision: 1495317
URL: http://svn.apache.org/r1495317
Log:
DERBY-673 Get rid of the NodeFactory
Patch derby-673-fixcomments; which fixes a couple of comments that
were accidentally changed by the first patch ("public" keyword was
removed).
Modified:
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ActivationClassBuilder.java
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentRowLocationNode.java
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ExpressionClassBuilder.java
Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ActivationClassBuilder.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ActivationClassBuilder.java?rev=1495317&r1=1495316&r2=1495317&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ActivationClassBuilder.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ActivationClassBuilder.java Fri Jun 21 08:14:22 2013
@@ -80,12 +80,12 @@ class ActivationClassBuilder extends Exp
/**
* By the time this is done, it has constructed the following class:
* <pre>
- * public class #className extends #superClass {
+ * final public class #className extends #superClass {
* // public void reset() { return; }
* protected ResultSet doExecute() throws StandardException {
* // statements must be added here
* }
- * #className() { super(); }
+ * public #className() { super(); }
* }
* </pre>
*
Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentRowLocationNode.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentRowLocationNode.java?rev=1495317&r1=1495316&r2=1495317&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentRowLocationNode.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentRowLocationNode.java Fri Jun 21 08:14:22 2013
@@ -86,7 +86,7 @@ class CurrentRowLocationNode extends Val
*
* ...
*
- * DataValueDescriptor exprx()
+ * protected DataValueDescriptor exprx()
* throws StandardException
* {
* return fieldx = <SQLRefConstructor>(
Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ExpressionClassBuilder.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ExpressionClassBuilder.java?rev=1495317&r1=1495316&r2=1495317&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ExpressionClassBuilder.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ExpressionClassBuilder.java Fri Jun 21 08:14:22 2013
@@ -91,8 +91,8 @@ abstract class ExpressionClassBuilder im
/**
* By the time this is done, it has constructed the following class:
* <pre>
- * class #className extends #superClass {
- * #className() { super(); }
+ * final public class #className extends #superClass {
+ * public #className() { super(); }
* }
* </pre>
*