[GitHub] [nifi] phrocker commented on a change in pull request #3174: NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11

[GitBox <gi...@apache.org>]

phrocker commented on a change in pull request #3174: NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11
URL: https://github.com/apache/nifi/pull/3174#discussion_r275848071
 
 

 ##########
 File path: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
 ##########
 @@ -993,6 +994,23 @@ public boolean accept(final File dir, final String filename) {
             cpFiles.add(file.getAbsolutePath());
         }
 
+        String runtimeJavaVersion = System.getProperty("java.version");
 
 Review comment:
   If I recall correctly, I think the only reason I mentioned that was to avoid issues with specification vs implementation version that are taken into account by commons lang. java.specification.version can be different from java.version in cases where bug fixes are applied to a different JRE or usage of a newer JRE are downgraded by force. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services