[GitHub] [maven-resolver] cstamas commented on pull request #218: [MRESOLVER-290] Expand use of atomic file ops

[GitBox <gi...@apache.org>]

cstamas commented on PR #218:
URL: https://github.com/apache/maven-resolver/pull/218#issuecomment-1312746749

   There's much more to do, but am stopping here due https://issues.apache.org/jira/browse/MRESOLVER-295.
   My plan is following:
   * component should use component (even if trivial as Slawek noted) to perform IO. Reason: components can be swapped out
   * split FileProcessor into PathProcessor (as name says, for files) and ChecksumProcessor (to read write checksums ONLY, to not mix concerns). This opens up the possibility to implement different ChecksumWriters (BSD/GNU/whatever), as currently we read BSD/GNU/resolver-native but write only resolver-native format.
   * but, due module layout (SPI not depending on Utils, and both Impl and Connector depending on SPI but Connector not on Impl) this needs a bit more work: see how many implementations of FileProcessor we have across, exactly for this reason. So, I want to do something with it.
   * direct use of static helper reduces testability, there is a nice test where file copy fails, that cannot be done if directly static helper used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org