You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/06/24 06:50:55 UTC
Review Request 22923: Explicitly terminated scheduler process in
~MesosSchedulerDriver().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22923/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-1534
https://issues.apache.org/jira/browse/MESOS-1534
Repository: mesos-git
Description
-------
Without this fix, Mesos tests that have assert failures get deadlocked on ~MesosSchedulerDriver() (because driver.stop() is not called) waiting forever for the scheduler process to exit. This causes the tests to never exit.
Diffs
-----
src/sched/sched.cpp 869f50a605a6a3d004609443b4c47d8b3a40d23c
Diff: https://reviews.apache.org/r/22923/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 22923: Explicitly terminated scheduler process in
~MesosSchedulerDriver().
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22923/#review46559
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 24, 2014, 4:50 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22923/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 4:50 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1534
> https://issues.apache.org/jira/browse/MESOS-1534
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Without this fix, Mesos tests that have assert failures get deadlocked on ~MesosSchedulerDriver() (because driver.stop() is not called) waiting forever for the scheduler process to exit. This causes the tests to never exit.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 869f50a605a6a3d004609443b4c47d8b3a40d23c
>
> Diff: https://reviews.apache.org/r/22923/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 22923: Explicitly terminated scheduler process in
~MesosSchedulerDriver().
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22923/#review46538
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On June 23, 2014, 9:50 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22923/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 9:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1534
> https://issues.apache.org/jira/browse/MESOS-1534
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Without this fix, Mesos tests that have assert failures get deadlocked on ~MesosSchedulerDriver() (because driver.stop() is not called) waiting forever for the scheduler process to exit. This causes the tests to never exit.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 869f50a605a6a3d004609443b4c47d8b3a40d23c
>
> Diff: https://reviews.apache.org/r/22923/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>