[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

["Alex Behm (Code Review)" <ge...@cloudera.org>]

Alex Behm has posted comments on this change.

Change subject: IMPALA-1702: Enforce unique table ID
......................................................................


Patch Set 2:

(1 comment)

I think we should avoid both forms of id inconsistency: Different tables with the same id, or the same table with different ids.

http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java:

Line 188:     private final HashMap<TTableName, TableId> tblIdMap_ =
Why do we need another map? Don't we already have a map of existing tables that we can use to get the current id?

I think it could actually be problematic to only rely on the TTableName for identification. The user could drop+add the same table and I think in that case a new id should be assigned. Thoughts?


-- 
To view, visit http://gerrit.cloudera.org:8080/4349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <hx...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hx...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes