[GitHub] [ignite] alex-plekhanov edited a comment on pull request #9176: IGNITE-13549 CREATE INDEX/DROP INDEX commands

[GitBox <gi...@apache.org>]

alex-plekhanov edited a comment on pull request #9176:
URL: https://github.com/apache/ignite/pull/9176#issuecomment-865013760


   > Looks like we could rework CREATE|DROP TABLE command to use NativeCommandHandler too. WDYT?
   
   Currently, `CommandProcessor` class supports two types of commands: instances of `SqlCommand` (ignite-core classes) and instances of `GridSqlStatement` (ignite-indexing classes). For some reason (unknown to me) `CREATE/DROP TABLE`, `ALTER TABLE ADD/DROP COLUMN`, and some other commands were implemented as `GridSqlStatement`, such commands can't be used by the calcite engine without additional references to the ignite-indexing module. Commands like `CREATE/DROP INDEX`, `ALTER TABLE LOGGING/NOLOGGING`, `CREATE/DROP/ALTER USER`, `KILL ...` and some other were implemented as `SqlCommand`, to support such commands in calcite engine we only need to add corresponding grammar and sql-to-cmd converter.
   So, we should move the `CREATE/DROP TABLE` command to the core module first (make it instance of `SqlCommand`) to be able to use it in `NativeCommandHandler`. Perhaps such refactoring should be done in the master branch to avoid merge conflicts.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org