You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/03/25 06:37:00 UTC

[jira] [Commented] (GEODE-9969) The region name starting with underscore lead to missing disk store after restart

    [ https://issues.apache.org/jira/browse/GEODE-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512211#comment-17512211 ] 

ASF subversion and git services commented on GEODE-9969:
--------------------------------------------------------

Commit e88d57da17cc86278754fece3f9d56ba5bb1440d in geode's branch refs/heads/develop from Mario Kevo
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e88d57d ]

GEODE-9969: Fix unescaping the region name with underscore (#7320)

* GEODE-9969: Fix unescaping the region name with underscore

* changes after review

* add acceptanceTest

* fix test

* fix windows test

* rebase on the latest develop

* empty commit to releaunch CI

> The region name starting with underscore lead to missing disk store after restart
> ---------------------------------------------------------------------------------
>
>                 Key: GEODE-9969
>                 URL: https://issues.apache.org/jira/browse/GEODE-9969
>             Project: Geode
>          Issue Type: Bug
>          Components: regions
>    Affects Versions: 1.12.8, 1.13.6, 1.14.2, 1.15.0
>            Reporter: Mario Kevo
>            Assignee: Mario Kevo
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> The problem is when using the region with a name starting with an underscore(allowed by documentation [region_naming|https://geode.apache.org/docs/guide/114/basic_config/data_regions/region_naming.html]).
> If we stop one of the members and then rename the working dir(include disk store dir) to some new name and start the server with the name like renamed working dir, it will lead that we have the same disk-store-id in the listed disk-stores and in the missing disk store.
> This happens only if we are using the region with an underscore at the beginning.
> Steps to reproduce:
> Run locator and 4 servers, create region with name starting by underscore
>  # start locator --name=locator
>  # start server --name=server1 --server-port=40401
>  # start server --name=server2 --server-port=40402
>  # start server --name=server3 --server-port=40403
>  # start server --name=server4 --server-port=40404
>  # create region --name=_test-region --type=PARTITION_REDUNDANT_PERSISTENT --redundant-copies=1 --total-num-buckets=10 --enable-synchronous-disk=false
>  # query --query="select * from /_test-region"
> From another terminal (Kill server and rename working dir)
>  # kill -9 $(cat server4/vf.gf.server.pid)
>  # mv server4/ server5
> {code:java}
> gfsh>list disk-stores
> Member Name |               Member Id                | Disk Store Name | Disk Store ID
> ----------- | -------------------------------------- | --------------- | ------------------------------------
> server1     | 192.168.0.145(server1:16916)<v1>:41001 | DEFAULT         | d5d17b43-4a06-408b-917f-08e5b2533ebe
> server2     | 192.168.0.145(server2:17004)<v2>:41002 | DEFAULT         | 31d47cb4-718e-4b58-bde3-ae15b4657910
> server3     | 192.168.0.145(server3:17094)<v3>:41003 | DEFAULT         | f12850c6-a73b-443e-9ee0-87f0819ae6bc
> server5     | 192.168.0.145(server5:17428)<v6>:41004 | DEFAULT         | 7a552fb3-e43d-4fa8-baa8-f6dc794cbf74
> gfsh>show missing-disk-stores
> Missing Disk Stores
>            Disk Store ID             |     Host      | Directory
> ------------------------------------ | ------------- | --------------------------------------------------------------------
> 7a552fb3-e43d-4fa8-baa8-f6dc794cbf74 | 192.168.0.145 | /home/mkevo/apache-geode-1.15.0-build.0/bin/server4/.
> No missing colocated region found
> {code}
> Start a new server with a name like you rename your working dir from the restarted server.
>  # start server --name=server5 --server-port=40405
> Now we have the following output:
> {code:java}
> gfsh>list disk-stores
> Member Name |               Member Id                | Disk Store Name | Disk Store ID
> ----------- | -------------------------------------- | --------------- | ------------------------------------
> server1     | 192.168.0.145(server1:16916)<v1>:41001 | DEFAULT         | d5d17b43-4a06-408b-917f-08e5b2533ebe
> server2     | 192.168.0.145(server2:17004)<v2>:41002 | DEFAULT         | 31d47cb4-718e-4b58-bde3-ae15b4657910
> server3     | 192.168.0.145(server3:17094)<v3>:41003 | DEFAULT         | f12850c6-a73b-443e-9ee0-87f0819ae6bc
> server5     | 192.168.0.145(server5:17428)<v6>:41004 | DEFAULT         | 7a552fb3-e43d-4fa8-baa8-f6dc794cbf74
> gfsh>show missing-disk-stores
> Missing Disk Stores
>            Disk Store ID             |     Host      | Directory
> ------------------------------------ | ------------- | --------------------------------------------------------------------
> 7a552fb3-e43d-4fa8-baa8-f6dc794cbf74 | 192.168.0.145 | /home/mkevo/apache-geode-1.15.0-build.0/bin/server4/.
> No missing colocated region found
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)