You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Iain Fogg (JIRA)" <ji...@apache.org> on 2007/01/02 05:27:27 UTC
[jira] Created: (OFBIZ-583) Offline payment selection now prevents
completion of sales order
Offline payment selection now prevents completion of sales order
----------------------------------------------------------------
Key: OFBIZ-583
URL: http://issues.apache.org/jira/browse/OFBIZ-583
Project: Apache OFBiz (The Open for Business Project)
Issue Type: Bug
Components: order
Reporter: Iain Fogg
Priority: Critical
I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
methodType = request.getParameter("paymentMethodType");
if ("offline".equals(methodType)) {
Debug.log("Changing mode from->to: " + mode + "->payment", module);
mode = "payment";
}
If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462085 ]
Scott Gray commented on OFBIZ-583:
----------------------------------
I understand your frustration Iain, but it does show the importance of trying out the patches that people submit. Tim and co. did ask for people to test the patch but I must admit I didn't, and if we had this might have been picked up and then fixed straight away prior to being commited.
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462086 ]
Anil K Patel commented on OFBIZ-583:
------------------------------------
I see the problem but, this actually does not touch the modifications done in ecommerce checkout process. In the mean time, I am looking at the problem, I post my comments ASAP.
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Iain Fogg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462119 ]
Iain Fogg commented on OFBIZ-583:
---------------------------------
Scott/Anil,
Thanks for the follow-up.
You're absolutely right about Tim and co, asking for people to test. I foolishly thought that since all the mods seemed to relate to anonymous checkout, then it wouldn't affect me - oops! Having said that, I've also become a little blase about incorporating patches, as generally I've found patchess to be pretty well tested and normally are backward compatibility (or at least "do no harm"). I think this one just fell through the cracks.
Please let me know if/when you find the solution - I'll be the first to patch and test!
Cheers, Iain
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462097 ]
Anil K Patel commented on OFBIZ-583:
------------------------------------
If you paste this following code at line # 253 in CheckOutEvents.java. I know this will fix the CreditCard problem.
if (paymentMethods == null) {
String paymentMethodId = (String) request.getAttribute("paymentMethodId");
if (paymentMethodId != null) {
String[] paymentMethodsTemp = {paymentMethodId};
paymentMethods = paymentMethodsTemp;
}
}
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462144 ]
Jacopo Cappellato commented on OFBIZ-583:
-----------------------------------------
I just created a sales order with offline payment in the demo server without any problems:
https://demo.dejc.com:8443/ordermgr/control/orderview?orderId=WS10001
How can I test this issue?
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462098 ]
Scott Gray commented on OFBIZ-583:
----------------------------------
It looks like some changes Jacopo made last month, I'll revert a few things and see what happens. Thanks for your help Anil
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461864 ]
Scott Gray commented on OFBIZ-583:
----------------------------------
That's the screen I'm getting to when trying offline payment except its not showing the CC stuff but just the billing address form
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: http://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Iain Fogg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461856 ]
Iain Fogg commented on OFBIZ-583:
---------------------------------
Scott,
Thanks for taking a look. When I tried it using CC payment, it took me to the next screen (entering CC details), but I didn't go further than that.
I agree it would be good if the folks who have worked on this recently taking a look to see if the previously working functionality can be reinstated.
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: http://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Iain Fogg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462081 ]
Iain Fogg commented on OFBIZ-583:
---------------------------------
I just wanted to keep this issue near the top of the list - would it be possible to the team who worked recently on the checkout process to take a look at this and at least let us know why offline payments no longer work.
I guess this raises a question about regression testing of significant new features, but that for another thread :-)
Cheers, Iain
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Iain Fogg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462214 ]
Iain Fogg commented on OFBIZ-583:
---------------------------------
Following Anil's lead, I made the following patches to CheckOutEvents.java:
Around line 715 (with Anil's patch) replace:
// check for offline payment type
// payment option; if offline we skip the payment screen
methodType = request.getParameter("paymentMethodType");
if ("offline".equals(methodType)) {
Debug.log("Changing mode from->to: " + mode + "->payment", module);
mode = "payment";
}
with:
// check for offline payment type
// payment option; if offline we skip the payment screen
HttpServletRequestWrapper wrapper = null;
methodType = request.getParameter("paymentMethodType");
if ("offline".equals(methodType)) {
Debug.log("Changing mode from->to: " + mode + "->payment", module);
mode = "payment";
wrapper = new HttpServletRequestWrapper((HttpServletRequest)request) {
public java.lang.String[] getParameterValues(java.lang.String name) {
if ("checkOutPaymentId".equals(name)) {
String[] ids = super.getParameterValues(name);
int len = ids != null ? ids.length + 1 : 1;
String[] ret = new String[len];
for (int i = 0; i < len - 1; i++) {
ret[i] = ids[i];
}
ret[len - 1] = "EXT_OFFLINE";
return ret;
}
else {
return super.getParameterValues(name);
}
}
};
}
and a little later (about line 747 or so), replace
Map selectedPaymentMethods = getSelectedPaymentMethods(request);
with
Map selectedPaymentMethods = getSelectedPaymentMethods(wrapper != null ? wrapper : request);
Since getSelectedPaymentMethods needs a HttpServletRequest param, we need to modify the request params on the way through. Apologies if there is a utility class available to add EXT_OFFLINE to other (possibly) existing checkOutPaymentId values, but I don't know if such exists.
I can test the patch for OFFLINE as well as BILLING_ACCOUNT payments, but I'm not configured to do online stuff like CC and EFT. I hope this gets us a little closer to a working solution.
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462148 ]
Scott Gray commented on OFBIZ-583:
----------------------------------
Hi Jacopo
You need to use a customer with no payment details previously loaded (like a credit card), try it with admin and you should see the problem.
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462094 ]
Anil K Patel commented on OFBIZ-583:
------------------------------------
I did some research, I think problem is in CheckOutEvents.java in getSelectedPaymentMethods. When a new PaymentMethod is created by the createCreditCard service and paymentMethodId is put in request.Attributes.
I think getSelectedPaymentMethods should be modified to also look for paymentMethodId instead of just looking for checkOutPaymentId. But this may not be rights because I don't understand the checkout process in Ordermanager.
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462151 ]
Anil K Patel commented on OFBIZ-583:
------------------------------------
This problem is reported when new payment method is created. Event for the customer that have payment methods, when we try to create new Payment Method, we get this error.
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: https://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-583) Offline payment selection now
prevents completion of sales order
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461847 ]
Scott Gray commented on OFBIZ-583:
----------------------------------
Hi Iain
I've had at look at this and the problem is not related to the code block you mention above. The problem is that the payment methods are never set in the cart so the system keeps thinking that payment is the next step to be completed. I tried to do it with CC payment to see what it does to get to the next step, but the same problem exists for all payment methods.
I would rather someone who knows more about the check process fixes this as I'm not sure where and when to set the payment method in the cart.
> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
> Key: OFBIZ-583
> URL: http://issues.apache.org/jira/browse/OFBIZ-583
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Iain Fogg
> Priority: Critical
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
> methodType = request.getParameter("paymentMethodType");
> if ("offline".equals(methodType)) {
> Debug.log("Changing mode from->to: " + mode + "->payment", module);
> mode = "payment";
> }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira