You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/26 05:03:53 UTC
[GitHub] [shardingsphere] lhyundeadsoul opened a new pull request, #20542: distinguish unexpected full-routing scenarios by different exception classes
lhyundeadsoul opened a new pull request, #20542:
URL: https://github.com/apache/shardingsphere/pull/20542
fix https://github.com/apache/shardingsphere/issues/19755
Changes proposed in this pull request:
- distinguish unexpected full-routing scenarios by different exception classes
-
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20542: distinguish unexpected full-routing scenarios by different exception classes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20542:
URL: https://github.com/apache/shardingsphere/pull/20542#issuecomment-1228186600
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20542?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20542](https://codecov.io/gh/apache/shardingsphere/pull/20542?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bba155) into [master](https://codecov.io/gh/apache/shardingsphere/commit/12a6e92e6e8585770e0861614f79da6d2fd9826a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12a6e92) will **decrease** coverage by `0.00%`.
> The diff coverage is `26.66%`.
```diff
@@ Coverage Diff @@
## master #20542 +/- ##
============================================
- Coverage 60.91% 60.91% -0.01%
- Complexity 2415 2416 +1
============================================
Files 3928 3938 +10
Lines 54781 54819 +38
Branches 9314 9313 -1
============================================
+ Hits 33372 33391 +19
- Misses 18571 18589 +18
- Partials 2838 2839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...harding/exception/CursorNameNotFoundException.java](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZXhjZXB0aW9uL0N1cnNvck5hbWVOb3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ption/ShardingAlgorithmLogicAbnormalException.java](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZXhjZXB0aW9uL1NoYXJkaW5nQWxnb3JpdGhtTG9naWNBYm5vcm1hbEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...gine/impl/InsertClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL2NvbmRpdGlvbi9lbmdpbmUvaW1wbC9JbnNlcnRDbGF1c2VTaGFyZGluZ0NvbmRpdGlvbkVuZ2luZS5qYXZh) | `79.41% <0.00%> (-2.41%)` | :arrow_down: |
| [.../exception/sql/ShardingKeyNotLiteralException.java](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leGNlcHRpb24vc3FsL1NoYXJkaW5nS2V5Tm90TGl0ZXJhbEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...fra/util/exception/sql/sqlstate/XOpenSQLState.java](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leGNlcHRpb24vc3FsL3NxbHN0YXRlL1hPcGVuU1FMU3RhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...phere/sharding/route/engine/ShardingSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL1NoYXJkaW5nU1FMUm91dGVyLmphdmE=) | `73.91% <60.00%> (-5.04%)` | :arrow_down: |
| [...rding/merge/ddl/fetch/FetchStreamMergedResult.java](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWVyZ2UvZGRsL2ZldGNoL0ZldGNoU3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `83.78% <100.00%> (-0.22%)` | :arrow_down: |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...ersist/service/DatabaseMetaDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL0RhdGFiYXNlTWV0YURhdGFQZXJzaXN0U2VydmljZS5qYXZh) | `44.44% <0.00%> (-4.54%)` | :arrow_down: |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9Db250ZXh0TWFuYWdlci5qYXZh) | `66.66% <0.00%> (-2.95%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/shardingsphere/pull/20542/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lhyundeadsoul commented on pull request #20542: distinguish unexpected full-routing scenarios by different exception classes
Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on PR #20542:
URL: https://github.com/apache/shardingsphere/pull/20542#issuecomment-1228058349
@strongduanmu I am trying to solve https://github.com/apache/shardingsphere/issues/19755.
But I am not sure if I find the right code location, especially in the second scenario(`The second is that the sharding algorithm logic is abnormal`)
I hope you can help me to review this PR. Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lhyundeadsoul closed pull request #20542: distinguish unexpected full-routing scenarios by different exception classes
Posted by GitBox <gi...@apache.org>.
lhyundeadsoul closed pull request #20542: distinguish unexpected full-routing scenarios by different exception classes
URL: https://github.com/apache/shardingsphere/pull/20542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org