You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Au-Miner (via GitHub)" <gi...@apache.org> on 2026/06/11 03:21:19 UTC
[PR] [FLINK-35012][table] Fix flaky ChangelogNormalizeRestoreTest by adding padding records to prevent mini-batch merging [flink]
Au-Miner opened a new pull request, #28382:
URL: https://github.com/apache/flink/pull/28382
## What is the purpose of the change
Fix the flaky `ChangelogNormalizeRestoreTest.testRestore` failure for the `changelog-normalize-source-mini-batch` variant. The test intermittently fails because `INSERT "six"` and `DELETE "six"` can end up in the same mini-batch, causing `addInput` to overwrite the INSERT with the DELETE, resulting in both records being silently dropped.
## Brief change log
- *[ChangelogNormalizeTestPrograms.java]* Added one no-op `DELETE` padding record (`"seven"`) to `AFTER_DATA` to ensure `INSERT "six"` and `DELETE "six"` are always separated into different mini-batches by `CountBundleTrigger(size=2)`, regardless of processing-time watermark timing.
## Verifying this change
This change is a test-only fix. The existing `ChangelogNormalizeRestoreTest.testRestore` test validates correctness. The padding DELETE records target non-existent keys, so they produce no output and do not affect `AFTER_OUTPUT` expectations.
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Currentity, Coordination, Zookeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35012][table] Fix flaky ChangelogNormalizeRestoreTest by adding padding records to prevent mini-batch merging [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #28382:
URL: https://github.com/apache/flink/pull/28382#issuecomment-4700474409
Hi, @bvarghese1 @dawidwys
Could you help take a look ? Many thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35012][table] Fix flaky ChangelogNormalizeRestoreTest by adding padding records to prevent mini-batch merging [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #28382:
URL: https://github.com/apache/flink/pull/28382#discussion_r4245866613
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/ChangelogNormalizeTestPrograms.java:
##########
@@ -54,6 +54,7 @@ public class ChangelogNormalizeTestPrograms {
Row.ofKind(RowKind.UPDATE_BEFORE, "four", 4, "d"),
Row.ofKind(RowKind.UPDATE_AFTER, "four", 4, "dd"),
Row.ofKind(RowKind.INSERT, "six", 6, "f"),
+ Row.ofKind(RowKind.DELETE, "seven", 7, "g"),
Review Comment:
This delete is for a key that was never inserted, so it only passes because ChangelogNormalize drops it. Could you move `+I six` after `+I five` instead, with a comment on the order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35012][table] Fix flaky ChangelogNormalizeRestoreTest by adding padding records to prevent mini-batch merging [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #28382:
URL: https://github.com/apache/flink/pull/28382#issuecomment-6113745390
Still relevant, I'll review this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35012][table] Fix flaky ChangelogNormalizeRestoreTest by adding padding records to prevent mini-batch merging [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28382:
URL: https://github.com/apache/flink/pull/28382#issuecomment-4676915519
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1529c08c15b7ac222eee0de7bb64bf6a33a26598",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1529c08c15b7ac222eee0de7bb64bf6a33a26598",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1529c08c15b7ac222eee0de7bb64bf6a33a26598 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35012][table] Fix flaky ChangelogNormalizeRestoreTest by adding padding records to prevent mini-batch merging [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28382:
URL: https://github.com/apache/flink/pull/28382#issuecomment-5644230882
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org