You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/04/30 23:53:35 UTC
[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #2974: [GOBBLIN-1135] added back flow remove feature for spec executors when dag manager is disabled
arjun4084346 commented on a change in pull request #2974:
URL: https://github.com/apache/incubator-gobblin/pull/2974#discussion_r418352329
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_executorInstance/AbstractSpecExecutor.java
##########
@@ -182,7 +183,7 @@ public int hashCode() {
abstract protected void shutDown() throws Exception;
- abstract public Future<? extends SpecProducer> getProducer();
+ abstract public Future<? extends SpecProducer<Spec>> getProducer();
Review comment:
I don't think so. We are actually not serializing/deserializing SpecProducer. We serialize/deserialize SpecExecutor and then find the producer from a mapping. After finding a producer we serialize/deserialize the onSpecAdd response Future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org