You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/07 09:57:27 UTC
[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request, #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator
SteNicholas opened a new pull request, #197:
URL: https://github.com/apache/flink-kubernetes-operator/pull/197
The core k8s related features:
- native k8s integration for session cluster, 1.10
- native k8s integration for application cluster, 1.11
- Flink K8s HA, 1.12
- pod template, 1.13
Hence required the minimum version could be set to 1.13 which allows more users to have a try on flink-kubernetes-operator. The e2e tests should be updated to cover all the supported versions.
**The brief change log**
- Add the `tests.sh` to cover all the supported versions for e2e tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on code in PR #197:
URL: https://github.com/apache/flink-kubernetes-operator/pull/197#discussion_r867833143
##########
e2e-tests/data/sessionjob-cr.yaml:
##########
@@ -76,7 +76,7 @@ metadata:
spec:
deploymentName: session-cluster-1
job:
- jarURI: https://repo1.maven.org/maven2/org/apache/flink/flink-examples-streaming_2.12/1.14.3/flink-examples-streaming_2.12-1.14.3.jar
+ jarURI: https://repo1.maven.org/maven2/org/apache/flink/flink-examples-streaming_2.12/1.13.6/flink-examples-streaming_2.12-1.13.6.jar
Review Comment:
I prefer to still use the 1.14 by default in the e2e tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 merged pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator
Posted by GitBox <gi...@apache.org>.
wangyang0918 merged PR #197:
URL: https://github.com/apache/flink-kubernetes-operator/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #197:
URL: https://github.com/apache/flink-kubernetes-operator/pull/197#issuecomment-1120187688
Maybe you could take something from my draft PR, especially for using the github action matrix. https://github.com/wangyang0918/flink-kubernetes-operator/commit/277b019ee3586186874a17baa83e49483192e803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on code in PR #197:
URL: https://github.com/apache/flink-kubernetes-operator/pull/197#discussion_r868774483
##########
e2e-tests/data/sessionjob-cr.yaml:
##########
@@ -22,8 +22,8 @@ metadata:
namespace: default
name: session-cluster-1
spec:
- image: flink:1.14.3
- flinkVersion: v1_14
+ image: flink:1.
Review Comment:
I got it. It is due to the `sed`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on code in PR #197:
URL: https://github.com/apache/flink-kubernetes-operator/pull/197#discussion_r868772741
##########
e2e-tests/data/sessionjob-cr.yaml:
##########
@@ -22,8 +22,8 @@ metadata:
namespace: default
name: session-cluster-1
spec:
- image: flink:1.14.3
- flinkVersion: v1_14
+ image: flink:1.
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on code in PR #197:
URL: https://github.com/apache/flink-kubernetes-operator/pull/197#discussion_r868772648
##########
e2e-tests/data/flinkdep-cr.yaml:
##########
@@ -22,8 +22,8 @@ metadata:
namespace: default
name: flink-example-statemachine
spec:
- image: flink:1.14.3
- flinkVersion: v1_14
+ image: flink:1.
+ flinkVersion: v1_
Review Comment:
It is strange that the e2e test does not fail with this typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on code in PR #197:
URL: https://github.com/apache/flink-kubernetes-operator/pull/197#discussion_r867839436
##########
.github/workflows/ci.yml:
##########
@@ -143,10 +150,13 @@ jobs:
kubectl get pods
- name: Run Flink e2e tests
run: |
+ sed -i "s/image: flink:.*/image: ${{ matrix.versions.image }}/" e2e-tests/data/*.yaml
+ sed -i "s/flinkVersion: .*/flinkVersion: ${{ matrix.versions.flinkVersion }}/" e2e-tests/data/*.yaml
ls e2e-tests/test_*.sh | while read script_test;do \
Review Comment:
I would like to add a `git diff HEAD` here to verify that the `sed` is executed successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org