You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2026/10/14 04:13:04 UTC

[PR] [fix](be) Reject BM25 scoring on non-tokenized SEARCH indexes [doris]

airborne12 opened a new pull request, #69051:
URL: https://github.com/apache/doris/pull/69051

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: None
   
   Problem Summary: A SEARCH query can match rows through a non-tokenized inverted index, while the same query with score() and descending top-k ordering can return no rows. The selected index has no norms and contributes zero tokens, leaving BM25 with a zero average document length and invalid scores that can be dropped during top-k collection. Validate the physical index selected for SEARCH scoring and return an explicit unsupported error when it is not analyzed. Keep analyzed-index scoring and ordinary SEARCH filtering intact.
   
   ### Release note
   
   SEARCH queries using score() now report an unsupported-index error when the selected inverted index is not analyzed.
   
   ### Check List (For Author)
   
   - Test
       - [ ] Regression test
       - [x] Unit Test: `GLIBC_COMPATIBILITY=OFF ./run-be-ut.sh --run --filter=CollectionStatisticsTest.* -j 24` (65 passed). The local toolchain has duplicate compatibility symbols when that option is on.
       - [ ] Manual test
       - [ ] No need to test or manual test
   
   A SEARCH SQL regression suite was added for descending top-k, disabled WAND, and ascending order. It was not run locally because no isolated Doris cluster was started. clang-format, check-format, and build hygiene passed. clang-tidy could not complete because of an existing unmatched NOLINTEND in `be/src/core/types.h`.
   
   - Behavior changed:
       - [ ] No.
       - [x] Yes. Scoring on a non-tokenized SEARCH index now returns a clear error.
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes.
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6183897966

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 153423 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit f22f16113644b4bbe254765329c92bdf8095593e, data reload: false
   
   query5	4319	596	456	456
   query6	423	210	190	190
   query7	4810	478	227	227
   query8	324	173	170	170
   query9	8751	4019	4033	4019
   query10	458	314	254	254
   query11	6022	3816	3585	3585
   query12	142	90	86	86
   query13	1268	457	339	339
   query14	6128	4155	3873	3873
   query14_1	3750	3559	3600	3559
   query15	210	208	180	180
   query16	943	440	422	422
   query17	867	664	543	543
   query18	2432	444	325	325
   query19	204	169	141	141
   query20	87	88	85	85
   query21	209	141	118	118
   query22	13042	13134	12827	12827
   query23	13595	12949	12507	12507
   query23_1	12701	12769	12723	12723
   query24	7082	881	478	478
   query24_1	482	490	487	487
   query25	545	423	373	373
   query26	1323	272	150	150
   query27	2742	459	281	281
   query28	4582	2000	1989	1989
   query29	1599	638	465	465
   query30	310	220	205	205
   query31	1013	942	819	819
   query32	154	111	88	88
   query33	534	318	250	250
   query34	917	889	515	515
   query35	758	779	656	656
   query36	836	788	731	731
   query37	129	108	95	95
   query38	1816	1778	1705	1705
   query39	805	795	762	762
   query39_1	745	754	750	750
   query40	221	124	104	104
   query41	75	70	69	69
   query42	87	87	83	83
   query43	376	392	343	343
   query44	1371	708	706	706
   query45	183	218	166	166
   query46	893	1006	591	591
   query47	3022	2947	2889	2889
   query48	303	315	218	218
   query49	573	405	296	296
   query50	719	288	222	222
   query51	10572	10497	10465	10465
   query52	79	81	71	71
   query53	193	225	157	157
   query54	237	190	174	174
   query55	72	69	68	68
   query56	245	223	201	201
   query57	1609	1582	1587	1582
   query58	279	264	269	264
   query59	2184	2145	1946	1946
   query60	277	241	222	222
   query61	146	148	149	148
   query62	399	344	287	287
   query63	201	172	178	172
   query64	2731	959	777	777
   query65	3335	3272	3287	3272
   query66	1807	453	298	298
   query67	20062	20385	19882	19882
   query68	2959	1027	644	644
   query69	391	297	251	251
   query70	912	840	820	820
   query71	294	245	215	215
   query72	2690	2566	2329	2329
   query73	540	564	305	305
   query74	4601	4503	4293	4293
   query75	2359	2307	1973	1973
   query76	2296	1058	633	633
   query77	359	396	289	289
   query78	9821	9750	9170	9170
   query79	996	867	551	551
   query80	1150	450	357	357
   query81	586	320	268	268
   query82	576	141	112	112
   query83	308	195	191	191
   query84	318	119	110	110
   query85	865	433	382	382
   query86	369	241	224	224
   query87	2025	1986	1838	1838
   query88	3663	2736	2724	2724
   query89	348	305	271	271
   query90	1813	185	185	185
   query91	182	154	129	129
   query92	102	88	80	80
   query93	1052	981	588	588
   query94	558	306	279	279
   query95	586	344	326	326
   query96	676	548	238	238
   query97	2491	2437	2311	2311
   query98	171	153	166	153
   query99	777	760	649	649
   Total cold run time: 235937 ms
   Total hot run time: 153423 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6261330946

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6262001469

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 24.61 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 9b356cb594f60b802de117ff9b5915b60500d424, data reload: false
   
   query1	0.01	0.00	0.01
   query2	0.10	0.05	0.05
   query3	0.26	0.12	0.11
   query4	1.61	0.12	0.12
   query5	0.24	0.21	0.24
   query6	1.17	0.69	0.67
   query7	0.03	0.00	0.00
   query8	0.05	0.03	0.04
   query9	0.41	0.34	0.35
   query10	0.58	0.60	0.57
   query11	0.19	0.14	0.13
   query12	0.18	0.14	0.14
   query13	0.48	0.48	0.48
   query14	1.04	1.01	1.01
   query15	0.64	0.60	0.59
   query16	0.33	0.35	0.35
   query17	1.11	1.14	1.10
   query18	0.23	0.21	0.21
   query19	2.14	1.99	1.94
   query20	0.02	0.02	0.01
   query21	15.47	0.28	0.14
   query22	4.36	0.05	0.05
   query23	16.27	0.32	0.12
   query24	2.77	0.73	0.41
   query25	0.09	0.06	0.04
   query26	1.74	0.25	0.16
   query27	0.05	0.03	0.03
   query28	2.48	0.63	0.40
   query29	12.52	4.28	3.40
   query30	0.29	0.14	0.15
   query31	2.77	0.57	0.34
   query32	3.22	0.61	0.52
   query33	3.29	3.22	3.22
   query34	15.44	4.03	3.41
   query35	3.36	3.36	3.35
   query36	0.56	0.47	0.47
   query37	0.09	0.06	0.06
   query38	0.05	0.03	0.03
   query39	0.03	0.03	0.03
   query40	0.17	0.14	0.15
   query41	0.09	0.03	0.03
   query42	0.03	0.04	0.03
   query43	0.04	0.04	0.03
   Total cold run time: 96 s
   Total hot run time: 24.61 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6264872539

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (7/7)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/69051_9b356cb594f60b802de117ff9b5915b60500d424_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/69051_9b356cb594f60b802de117ff9b5915b60500d424_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 77.26% (35797/46336) |
   | Line Coverage     | 62.47% (404027/646735) |
   | Region Coverage   | 58.91% (341148/579066) |
   | Branch Coverage   | 59.88% (157695/263364) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6261329500

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #69051:
URL: https://github.com/apache/doris/pull/69051#discussion_r4295241438


##########
be/src/storage/index/inverted/reader/collection_statistics.cpp:
##########
@@ -43,8 +43,10 @@ namespace collection_statistics_detail {
 
 Result<SniiScoringSegmentStats> resolve_snii_scoring_segment(uint64_t index_doc_count,
                                                              uint64_t sum_total_term_freq,
-                                                             bool has_positions, bool has_norms) {
-    if (!has_positions || !has_norms) {
+                                                             bool has_positions, bool has_norms,
+                                                             bool is_analyzed) {
+    // A keyword posting has implicit frequency and length one, without either section.
+    if (is_analyzed && (!has_positions || !has_norms)) {

Review Comment:
   [P1] Support docs-only keywords in scored SNII conjunctions
   
   This now admits keyword SNII indexes without positions, but the scored AND path still requires them. On the SNII schema from the new keyword-filter regression, `SELECT id, score() AS s FROM t WHERE SEARCH('body:apple AND tag:x', '{"mode":"standard"}') ORDER BY s DESC LIMIT 10` reaches `OperatorBooleanWeight::listed_terms`. SNII sources always batch reads, including a single `tag` term, so `ListedTerms::open(true, true)` calls `open_terms(..., positions=true, scoring=false)`; `SniiIndexSource` rejects the keyword source with `snii: the index holds no positions`. Support implicit unit frequencies in this conjunction path or use the individual term scorers, and add an internal SEARCH AND regression with WAND on/off. The new SQL AND filter cases do not exercise this path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6183117302

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6183788292

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29865 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit f22f16113644b4bbe254765329c92bdf8095593e, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17599	5722	5597	5597
   q2	2087	306	258	258
   q3	10247	1467	878	878
   q4	4681	480	343	343
   q5	7444	813	547	547
   q6	198	194	171	171
   q7	805	818	621	621
   q8	9254	1385	1241	1241
   q9	5695	4343	4344	4343
   q10	6839	1289	1039	1039
   q11	447	265	242	242
   q12	634	409	306	306
   q13	18089	5629	2982	2982
   q14	289	271	245	245
   q15	q16	745	735	678	678
   q17	1233	779	574	574
   q18	7116	6334	6225	6225
   q19	1257	981	626	626
   q20	414	347	231	231
   q21	6167	2445	2514	2445
   q22	389	332	273	273
   Total cold run time: 101629 ms
   Total hot run time: 29865 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	6278	6250	6199	6199
   q2	770	576	550	550
   q3	5294	5423	4903	4903
   q4	2048	2144	1637	1637
   q5	5497	6087	5821	5821
   q6	267	197	157	157
   q7	2423	2089	2019	2019
   q8	3360	2851	2917	2851
   q9	8118	8032	8247	8032
   q10	3756	3808	3405	3405
   q11	667	447	436	436
   q12	723	723	540	540
   q13	3682	4174	3211	3211
   q14	317	333	296	296
   q15	q16	719	727	673	673
   q17	8514	7755	7500	7500
   q18	13138	12317	13137	12317
   q19	990	865	858	858
   q20	2199	2197	1929	1929
   q21	6137	5053	5092	5053
   q22	514	459	417	417
   Total cold run time: 75411 ms
   Total hot run time: 68804 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6211364505

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6212937698

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 152347 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 46e15abe616fc95d28205580115148c0e0750d37, data reload: false
   
   query5	4317	598	449	449
   query6	433	244	226	226
   query7	4817	460	256	256
   query8	346	180	161	161
   query9	8776	4035	4026	4026
   query10	468	312	262	262
   query11	6024	3790	3553	3553
   query12	142	92	90	90
   query13	1238	431	313	313
   query14	6141	4029	3800	3800
   query14_1	3517	3512	3568	3512
   query15	206	197	177	177
   query16	950	440	411	411
   query17	830	633	524	524
   query18	2411	425	298	298
   query19	204	188	139	139
   query20	88	84	81	81
   query21	215	140	117	117
   query22	12955	12986	12826	12826
   query23	13335	12772	12468	12468
   query23_1	12507	12465	12505	12465
   query24	7135	819	461	461
   query24_1	475	471	482	471
   query25	534	442	363	363
   query26	1278	261	140	140
   query27	2761	439	274	274
   query28	4665	1968	1956	1956
   query29	1591	607	457	457
   query30	308	224	190	190
   query31	1015	934	807	807
   query32	152	95	96	95
   query33	533	315	256	256
   query34	1030	856	504	504
   query35	753	752	638	638
   query36	816	814	731	731
   query37	135	109	90	90
   query38	1780	1765	1709	1709
   query39	801	817	751	751
   query39_1	742	740	750	740
   query40	221	116	98	98
   query41	74	67	72	67
   query42	86	86	84	84
   query43	374	382	338	338
   query44	1363	710	715	710
   query45	185	182	166	166
   query46	851	966	565	565
   query47	2964	3009	2933	2933
   query48	303	320	223	223
   query49	577	409	301	301
   query50	673	284	218	218
   query51	10340	10251	10529	10251
   query52	80	82	71	71
   query53	191	213	161	161
   query54	262	208	183	183
   query55	74	76	67	67
   query56	234	235	216	216
   query57	1630	1585	1558	1558
   query58	298	275	267	267
   query59	2142	2146	1937	1937
   query60	284	251	235	235
   query61	166	201	141	141
   query62	383	339	285	285
   query63	209	162	172	162
   query64	2733	954	775	775
   query65	3311	3250	3240	3240
   query66	1790	413	305	305
   query67	20158	19987	19925	19925
   query68	2941	1015	617	617
   query69	380	291	254	254
   query70	863	808	794	794
   query71	289	231	210	210
   query72	2699	2546	2342	2342
   query73	526	543	298	298
   query74	4607	4461	4306	4306
   query75	2348	2321	1966	1966
   query76	2292	1028	625	625
   query77	349	381	288	288
   query78	9734	9821	9114	9114
   query79	974	912	520	520
   query80	656	422	369	369
   query81	554	316	279	279
   query82	673	139	116	116
   query83	269	195	183	183
   query84	315	127	100	100
   query85	867	426	364	364
   query86	351	241	232	232
   query87	2009	1953	1830	1830
   query88	3655	2714	2679	2679
   query89	346	310	270	270
   query90	1789	188	191	188
   query91	165	156	128	128
   query92	104	92	89	89
   query93	1020	1005	582	582
   query94	493	320	308	308
   query95	596	348	371	348
   query96	670	529	233	233
   query97	2506	2406	2311	2311
   query98	163	153	147	147
   query99	779	767	656	656
   Total cold run time: 234087 ms
   Total hot run time: 152347 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6260789026

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6183116060

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Reject BM25 scoring on non-tokenized SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6160725302

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6282106932

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6212767599

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29766 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 46e15abe616fc95d28205580115148c0e0750d37, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17590	5698	5545	5545
   q2	2095	327	258	258
   q3	10241	1435	845	845
   q4	4683	476	337	337
   q5	7426	833	542	542
   q6	200	194	160	160
   q7	791	801	601	601
   q8	9257	1389	1115	1115
   q9	5560	4285	4277	4277
   q10	6844	1296	1034	1034
   q11	453	256	243	243
   q12	642	404	294	294
   q13	18065	3668	3015	3015
   q14	277	267	251	251
   q15	q16	731	730	664	664
   q17	1203	748	577	577
   q18	7139	6242	6170	6170
   q19	1099	969	632	632
   q20	391	342	227	227
   q21	5784	2670	2687	2670
   q22	394	354	309	309
   Total cold run time: 100865 ms
   Total hot run time: 29766 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	6697	6676	6826	6676
   q2	745	608	582	582
   q3	5637	5703	5299	5299
   q4	2076	2160	1707	1707
   q5	5687	5490	5769	5490
   q6	249	197	154	154
   q7	2248	2023	1846	1846
   q8	3284	2790	2785	2785
   q9	8138	8007	7943	7943
   q10	3642	3580	3230	3230
   q11	595	418	396	396
   q12	659	692	500	500
   q13	3354	3608	2990	2990
   q14	285	289	274	274
   q15	q16	673	686	624	624
   q17	7828	7037	6979	6979
   q18	13260	12306	13161	12306
   q19	963	853	849	849
   q20	2185	2171	1935	1935
   q21	6140	5133	5172	5133
   q22	531	470	402	402
   Total cold run time: 74876 ms
   Total hot run time: 68100 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6213019650

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 24.75 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 46e15abe616fc95d28205580115148c0e0750d37, data reload: false
   
   query1	0.01	0.01	0.01
   query2	0.10	0.05	0.04
   query3	0.27	0.12	0.11
   query4	1.60	0.13	0.12
   query5	0.25	0.27	0.25
   query6	1.17	0.69	0.68
   query7	0.04	0.01	0.00
   query8	0.05	0.04	0.04
   query9	0.40	0.32	0.34
   query10	0.57	0.57	0.59
   query11	0.22	0.15	0.13
   query12	0.19	0.15	0.14
   query13	0.50	0.51	0.49
   query14	1.03	1.01	1.00
   query15	0.65	0.60	0.62
   query16	0.36	0.35	0.35
   query17	1.18	1.17	1.16
   query18	0.23	0.21	0.24
   query19	2.12	2.01	1.99
   query20	0.01	0.01	0.02
   query21	15.53	0.26	0.14
   query22	4.49	0.06	0.06
   query23	16.22	0.32	0.12
   query24	3.04	1.10	0.45
   query25	0.10	0.04	0.05
   query26	1.68	0.27	0.15
   query27	0.05	0.05	0.06
   query28	2.04	0.68	0.42
   query29	12.48	4.26	3.35
   query30	0.28	0.14	0.14
   query31	2.79	0.59	0.34
   query32	3.22	0.62	0.52
   query33	3.16	3.18	3.19
   query34	15.51	4.03	3.40
   query35	3.33	3.37	3.36
   query36	0.55	0.43	0.44
   query37	0.10	0.06	0.07
   query38	0.05	0.04	0.04
   query39	0.03	0.03	0.03
   query40	0.18	0.15	0.14
   query41	0.09	0.04	0.04
   query42	0.04	0.03	0.03
   query43	0.04	0.04	0.04
   Total cold run time: 95.95 s
   Total hot run time: 24.75 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6221646331

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (7/7)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/69051_1c146c172aaf4c308563b9aa0abe2943b6d086e0_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/69051_1c146c172aaf4c308563b9aa0abe2943b6d086e0_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 77.05% (35682/46313) |
   | Line Coverage     | 62.29% (402645/646436) |
   | Region Coverage   | 58.65% (339409/578696) |
   | Branch Coverage   | 59.64% (156942/263144) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6183951996

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 24.77 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit f22f16113644b4bbe254765329c92bdf8095593e, data reload: false
   
   query1	0.01	0.00	0.01
   query2	0.09	0.05	0.05
   query3	0.26	0.12	0.12
   query4	1.61	0.13	0.13
   query5	0.29	0.27	0.26
   query6	1.17	0.69	0.68
   query7	0.04	0.00	0.01
   query8	0.05	0.04	0.03
   query9	0.42	0.36	0.35
   query10	0.59	0.61	0.63
   query11	0.21	0.15	0.14
   query12	0.19	0.14	0.15
   query13	0.50	0.50	0.52
   query14	1.02	1.05	1.02
   query15	0.66	0.61	0.64
   query16	0.36	0.32	0.34
   query17	1.17	1.16	1.12
   query18	0.23	0.22	0.21
   query19	2.09	2.05	2.02
   query20	0.02	0.01	0.01
   query21	15.48	0.26	0.15
   query22	4.40	0.05	0.06
   query23	16.26	0.33	0.12
   query24	3.15	0.63	0.36
   query25	0.13	0.05	0.06
   query26	1.22	0.24	0.14
   query27	0.05	0.03	0.04
   query28	1.96	0.69	0.44
   query29	12.53	4.23	3.36
   query30	0.29	0.15	0.13
   query31	2.78	0.58	0.34
   query32	3.22	0.63	0.52
   query33	3.23	3.21	3.24
   query34	15.54	4.02	3.42
   query35	3.36	3.36	3.33
   query36	0.56	0.46	0.44
   query37	0.09	0.06	0.06
   query38	0.05	0.04	0.04
   query39	0.04	0.03	0.03
   query40	0.18	0.15	0.14
   query41	0.08	0.03	0.03
   query42	0.03	0.03	0.03
   query43	0.04	0.03	0.04
   Total cold run time: 95.65 s
   Total hot run time: 24.77 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6260789806

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #69051:
URL: https://github.com/apache/doris/pull/69051


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #69051:
URL: https://github.com/apache/doris/pull/69051#discussion_r4278499777


##########
be/src/storage/index/snii/snii_index_reader.cpp:
##########
@@ -643,8 +644,8 @@ Status SniiIndexReader::_query(const IndexQueryContextPtr& context, const std::s
     }
 
     const bool actual_similarity =
-            context->collection_similarity &&
-            IndexReaderHelper::is_need_similarity_score(query_type, &_index_meta);
+            context->collection_similarity && IndexReaderHelper::is_need_snii_similarity_score(

Review Comment:
   [P1] Keep uncollected keyword filters out of the scoring path
   
   `_query()` is also used by ordinary SQL filters, and `SegmentIterator::_init_index_iterators()` attaches the same non-null `collection_similarity` to every iterator in a score query. On an SNII table with an analyzed `body` index and a keyword `tag` index, `SELECT id, score() AS s FROM t WHERE SEARCH('body:apple') AND tag = 'x' ORDER BY s DESC LIMIT 10` now sends the tag's `EQUAL_QUERY` through `score_plain_term_candidates()`. However, `CollectionStatistics::extract_collect_info()` only collects MATCH/SEARCH leaves, so no statistics exist for the equality filter's tag field: `get_or_calculate_avg_dl()` throws `Index statistics collection failed: Not such column ...`, failing a query that previously worked. Keyword MATCH predicates have the same mismatch because `MatchPredicateCollector` explicitly skips non-analyzed indexes. Please distinguish SEARCH leaf scoring from ordinary filters, and keep reader eligibility consistent with the statistics collected for each caller; add an SNI
 I regression combining SEARCH/score() with an indexed keyword equality or MATCH filter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6185610334

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (30/30)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/69051_f22f16113644b4bbe254765329c92bdf8095593e_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/69051_f22f16113644b4bbe254765329c92bdf8095593e_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 77.10% (35633/46218) |
   | Line Coverage     | 62.35% (403400/646976) |
   | Region Coverage   | 58.74% (340580/579805) |
   | Branch Coverage   | 59.65% (156889/263033) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6211360633

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6229523121

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (7/7)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/69051_1c146c172aaf4c308563b9aa0abe2943b6d086e0_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/69051_1c146c172aaf4c308563b9aa0abe2943b6d086e0_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 77.19% (35747/46313) |
   | Line Coverage     | 62.43% (403574/646436) |
   | Region Coverage   | 58.85% (340537/578696) |
   | Branch Coverage   | 59.80% (157354/263144) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6261922400

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 152370 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 9b356cb594f60b802de117ff9b5915b60500d424, data reload: false
   
   query5	4285	596	470	470
   query6	431	232	200	200
   query7	4795	443	232	232
   query8	316	167	154	154
   query9	8766	3975	3985	3975
   query10	473	310	257	257
   query11	6078	3771	3537	3537
   query12	147	92	90	90
   query13	1256	456	331	331
   query14	6129	4028	3764	3764
   query14_1	3509	3474	3477	3474
   query15	211	198	187	187
   query16	961	448	421	421
   query17	843	638	526	526
   query18	2464	424	302	302
   query19	196	157	126	126
   query20	86	86	84	84
   query21	222	131	111	111
   query22	12901	13108	12678	12678
   query23	13549	12885	12454	12454
   query23_1	12749	12655	12663	12655
   query24	7080	851	452	452
   query24_1	477	456	472	456
   query25	518	396	337	337
   query26	1197	251	135	135
   query27	2782	437	267	267
   query28	4625	1975	1944	1944
   query29	1523	595	451	451
   query30	294	229	189	189
   query31	1032	933	815	815
   query32	155	99	96	96
   query33	514	310	243	243
   query34	919	866	498	498
   query35	764	781	658	658
   query36	812	829	709	709
   query37	131	104	91	91
   query38	1806	1732	1670	1670
   query39	808	826	752	752
   query39_1	736	737	757	737
   query40	231	131	98	98
   query41	75	70	68	68
   query42	91	89	84	84
   query43	367	376	341	341
   query44	1284	714	702	702
   query45	185	179	162	162
   query46	855	965	575	575
   query47	2971	2966	2896	2896
   query48	306	321	228	228
   query49	579	407	306	306
   query50	702	287	222	222
   query51	10654	10509	10281	10281
   query52	84	91	73	73
   query53	188	217	155	155
   query54	247	206	210	206
   query55	78	71	68	68
   query56	242	246	224	224
   query57	1583	1589	1571	1571
   query58	300	277	268	268
   query59	2206	2114	2044	2044
   query60	305	245	240	240
   query61	173	170	164	164
   query62	396	349	294	294
   query63	199	168	173	168
   query64	2860	983	763	763
   query65	3286	3255	3254	3254
   query66	1767	415	323	323
   query67	20384	20159	20198	20159
   query68	3279	989	607	607
   query69	389	277	240	240
   query70	851	768	864	768
   query71	298	229	191	191
   query72	2794	2584	2340	2340
   query73	525	533	292	292
   query74	4597	4463	4343	4343
   query75	2347	2288	1928	1928
   query76	2370	1023	606	606
   query77	356	419	277	277
   query78	9842	9761	9171	9171
   query79	993	856	520	520
   query80	1273	421	345	345
   query81	593	315	274	274
   query82	770	134	107	107
   query83	300	195	188	188
   query84	311	120	98	98
   query85	887	431	383	383
   query86	405	231	231	231
   query87	2009	1933	1826	1826
   query88	3616	2721	2697	2697
   query89	338	296	259	259
   query90	1920	180	179	179
   query91	164	153	131	131
   query92	94	88	93	88
   query93	985	983	565	565
   query94	643	321	269	269
   query95	582	401	317	317
   query96	668	536	233	233
   query97	2500	2447	2337	2337
   query98	170	152	148	148
   query99	787	759	650	650
   Total cold run time: 236020 ms
   Total hot run time: 152370 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6261403148

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29549 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c52cdfb6a0640884b46fad7b00b6c10a032a4e9f, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17593	5626	5517	5517
   q2	2105	352	248	248
   q3	10223	1401	843	843
   q4	4684	478	350	350
   q5	7443	793	530	530
   q6	193	190	156	156
   q7	746	802	606	606
   q8	9253	1318	1072	1072
   q9	5520	4278	4259	4259
   q10	6824	1303	1037	1037
   q11	448	250	238	238
   q12	635	396	291	291
   q13	18100	3651	2996	2996
   q14	267	273	247	247
   q15	q16	744	726	679	679
   q17	1195	764	567	567
   q18	7154	6256	6208	6208
   q19	1265	958	598	598
   q20	400	352	225	225
   q21	5531	2584	2616	2584
   q22	399	362	298	298
   Total cold run time: 100722 ms
   Total hot run time: 29549 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	6508	6655	6366	6366
   q2	725	610	600	600
   q3	5678	5753	5251	5251
   q4	2043	2098	1594	1594
   q5	5772	5796	5566	5566
   q6	248	192	141	141
   q7	2229	2059	1770	1770
   q8	3026	2720	2706	2706
   q9	8080	7698	7542	7542
   q10	3659	3611	3226	3226
   q11	596	406	374	374
   q12	669	696	499	499
   q13	3274	3602	3025	3025
   q14	291	296	262	262
   q15	q16	666	690	633	633
   q17	7746	6988	6855	6855
   q18	13045	12213	13078	12213
   q19	916	783	780	780
   q20	2173	2154	1958	1958
   q21	5762	4672	4804	4672
   q22	512	455	388	388
   Total cold run time: 73618 ms
   Total hot run time: 66421 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](be) Support BM25 scoring on keyword SEARCH indexes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69051:
URL: https://github.com/apache/doris/pull/69051#issuecomment-6261771716

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29326 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 9b356cb594f60b802de117ff9b5915b60500d424, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17589	5668	5540	5540
   q2	2120	331	271	271
   q3	10210	1412	856	856
   q4	4684	475	340	340
   q5	7436	800	541	541
   q6	200	195	158	158
   q7	766	802	613	613
   q8	10018	1360	1111	1111
   q9	5730	4294	4284	4284
   q10	6901	1303	1030	1030
   q11	451	256	243	243
   q12	636	408	284	284
   q13	18109	3562	2993	2993
   q14	279	276	244	244
   q15	q16	730	731	687	687
   q17	1221	770	585	585
   q18	7069	6242	6181	6181
   q19	1115	973	595	595
   q20	397	350	237	237
   q21	4894	2269	2404	2269
   q22	369	321	264	264
   Total cold run time: 100924 ms
   Total hot run time: 29326 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	6156	6158	6147	6147
   q2	700	568	536	536
   q3	5209	5462	4984	4984
   q4	2017	2115	1549	1549
   q5	5333	5200	5172	5172
   q6	246	185	144	144
   q7	2121	1858	1698	1698
   q8	2962	2560	2571	2560
   q9	7675	7622	7631	7622
   q10	3691	3594	3250	3250
   q11	605	426	379	379
   q12	673	701	505	505
   q13	3270	3705	2967	2967
   q14	291	291	287	287
   q15	q16	662	697	624	624
   q17	7869	7059	6894	6894
   q18	13129	12207	13129	12207
   q19	935	808	819	808
   q20	2185	2172	1941	1941
   q21	5853	4744	4818	4744
   q22	504	459	413	413
   Total cold run time: 72086 ms
   Total hot run time: 65431 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org