You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/02/28 10:54:35 UTC
[GitHub] [echarts] gsi7 opened a new pull request #14371: feat(brush): user can provide cursor style. close #13712
gsi7 opened a new pull request #14371:
URL: https://github.com/apache/echarts/pull/14371
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
User can now provide cursor style when mouse is inside and outside the brush.
### Fixed issues
<!--
- #13712: Support cursor option in brush
-->
## Details
Added field `cursor` for cursor style in `inBrush` and `outOfBrush`.
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
Earlier there was default cursor for brush ie crosshair for out of the brush and move for within the brush. User was unable to customize that.
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
User can now provide cursor style when mouse is inside and outside the brush. Added field `cursor` for cursor style in `inBrush` and `outOfBrush`.
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Usage
User can now provide cursor style when mouse is inside and outside the brush.
### Are there any API changes?
- [x] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
- Added field `cursor` for cursor style in `inBrush` and `outOfBrush`.
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] susiwen8 commented on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-787433546
Thanks for your help, but first, please do not commit any file in `dist`, only `src`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] gsi7 edited a comment on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
gsi7 edited a comment on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-796616254
When does the PR get reviewed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-787432999
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
Document changes are required in this PR. Please also make a PR to [apache/incubator-echarts-doc](https://github.com/apache/incubator-echarts-doc) for document changes. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] gsi7 edited a comment on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
gsi7 edited a comment on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-787434839
> Thanks for your help, but first, please do not commit any file in `dist`, only `src`.
Should I revert the changes in `dist` dir and push a new commit?
I'm just starting the contributions, thanks for your help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-797186701
@g7i Thanks, we plan this PR in 5.2.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-797186701
@g7i Thanks, we will merge this PR in 5.2.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] gsi7 commented on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
gsi7 commented on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-787434839
> Thanks for your help, but first, please do not commit any file in `dist`, only `src`.
Should I revert the changes and push a new commit?
I'm just starting the contributions, thanks for your help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] g7i commented on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
g7i commented on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-880725326
@pissang @plainheart @susiwen8 I have resolved the conflicts, so its ready to be reviewed. Thanks...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] gsi7 commented on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
gsi7 commented on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-796616254
When does the PR gets reviewed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] gsi7 commented on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
gsi7 commented on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-787434147
Alright @susiwen8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] susiwen8 commented on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-787435286
> Should I revert the changes in `dist` dir and push a new commit?
Yes, you could.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #14371: feat(brush): user can provide cursor style. close #13712
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #14371:
URL: https://github.com/apache/echarts/pull/14371#issuecomment-797186701
@g7i Thanks, it's planned in 5.2.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org