[GitHub] [dubbo-go] AlexStocks commented on issue #1892: Ref: Maybe use the same const in graceful_shutdown_config.go and graceful_shutdown.go?

[GitBox <gi...@apache.org>]

AlexStocks commented on issue #1892:
URL: https://github.com/apache/dubbo-go/issues/1892#issuecomment-1127011558

   > https://github.com/apache/dubbo-go/blob/4a62aa28e4f942db4c02c0725ad2a77cbbbd9db7/config/graceful_shutdown_config.go#L36
   > 
   > https://github.com/apache/dubbo-go/blob/4a62aa28e4f942db4c02c0725ad2a77cbbbd9db7/config/graceful_shutdown.go#L54
   > 
   > **What would you like to be added**: Just use the same const. 使用同一个常量值便可。
   > 
   > Should it be changed in config/graceful_shutdown.go? 是否应该在 config/graceful_shutdown.go 中更改？
   > 
   > ```go
   > const defaultShutDownTime = defaultTimeout
   > ```
   > 
   > **Why is this needed**: Const that seem to have the same effect are now defined in two places. 现在看似同样作用的常量值被定义在两个地方。
   
   变量意义不一样，不宜统一成一个吧。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org