You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "John Wang (JIRA)" <ji...@apache.org> on 2008/12/31 22:11:44 UTC
[jira] Created: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Adding FilteredDocIdSet and FilteredDocIdSetIterator
----------------------------------------------------
Key: LUCENE-1506
URL: https://issues.apache.org/jira/browse/LUCENE-1506
Project: Lucene - Java
Issue Type: Improvement
Components: Search
Affects Versions: 2.4
Reporter: John Wang
Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Posted by "John Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Wang updated LUCENE-1506:
------------------------------
Attachment: filteredDocidset.txt
> Adding FilteredDocIdSet and FilteredDocIdSetIterator
> ----------------------------------------------------
>
> Key: LUCENE-1506
> URL: https://issues.apache.org/jira/browse/LUCENE-1506
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.4
> Reporter: John Wang
> Attachments: filteredDocidset.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668399#action_12668399 ]
Michael McCandless commented on LUCENE-1506:
--------------------------------------------
OK, I see. That is an important difference; I think it makes sense to add this. Could you add javadocs & a unit test? Thanks John.
> Adding FilteredDocIdSet and FilteredDocIdSetIterator
> ----------------------------------------------------
>
> Key: LUCENE-1506
> URL: https://issues.apache.org/jira/browse/LUCENE-1506
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.4
> Reporter: John Wang
> Attachments: filteredDocidset.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Posted by "John Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668244#action_12668244 ]
John Wang commented on LUCENE-1506:
-----------------------------------
Filter calculates a DocSet given an IndexReader. Imagine a large index, and the logic to calculate whether it is in the set is non-trivial, so building this DocSet can be expensive.
So in the case where the driving query produces a very small result set, the validation can be performed only on the small set via the match call.
Yes, in terms of functionality, one can do this with a filter, but it is wasteful to perform the validation calculation on the entire index where the candidates to be in the hits set is small.
> Adding FilteredDocIdSet and FilteredDocIdSetIterator
> ----------------------------------------------------
>
> Key: LUCENE-1506
> URL: https://issues.apache.org/jira/browse/LUCENE-1506
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.4
> Reporter: John Wang
> Attachments: filteredDocidset.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1506:
---------------------------------------
Attachment: LUCENE-1506.patch
Thanks John! I made a few tweaks ("downgraded" to Java 1.4, expanded javadocs, fixed whitespace, etc.). I think it's ready to commit. I'll wait a day or two.
> Adding FilteredDocIdSet and FilteredDocIdSetIterator
> ----------------------------------------------------
>
> Key: LUCENE-1506
> URL: https://issues.apache.org/jira/browse/LUCENE-1506
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.4
> Reporter: John Wang
> Assignee: Michael McCandless
> Attachments: filteredDocidset.txt, filteredDocidset2.txt, LUCENE-1506.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-1506:
------------------------------------------
Assignee: Michael McCandless
> Adding FilteredDocIdSet and FilteredDocIdSetIterator
> ----------------------------------------------------
>
> Key: LUCENE-1506
> URL: https://issues.apache.org/jira/browse/LUCENE-1506
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.4
> Reporter: John Wang
> Assignee: Michael McCandless
> Attachments: filteredDocidset.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Posted by "John Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Wang updated LUCENE-1506:
------------------------------
Attachment: filteredDocidset2.txt
javadoc and unit test added
> Adding FilteredDocIdSet and FilteredDocIdSetIterator
> ----------------------------------------------------
>
> Key: LUCENE-1506
> URL: https://issues.apache.org/jira/browse/LUCENE-1506
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.4
> Reporter: John Wang
> Assignee: Michael McCandless
> Attachments: filteredDocidset.txt, filteredDocidset2.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Posted by "John Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669105#action_12669105 ]
John Wang commented on LUCENE-1506:
-----------------------------------
Thanks Michael!
> Adding FilteredDocIdSet and FilteredDocIdSetIterator
> ----------------------------------------------------
>
> Key: LUCENE-1506
> URL: https://issues.apache.org/jira/browse/LUCENE-1506
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.4
> Reporter: John Wang
> Assignee: Michael McCandless
> Attachments: filteredDocidset.txt, filteredDocidset2.txt, LUCENE-1506.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667994#action_12667994 ]
Michael McCandless commented on LUCENE-1506:
--------------------------------------------
Can't this functionality be achieved via a normal Filter (and
ChainedFilter if you need to AND two Filters together)? Ie, why
introduce a new interface (with the "match" method)?
> Adding FilteredDocIdSet and FilteredDocIdSetIterator
> ----------------------------------------------------
>
> Key: LUCENE-1506
> URL: https://issues.apache.org/jira/browse/LUCENE-1506
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.4
> Reporter: John Wang
> Attachments: filteredDocidset.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1506.
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.9
Lucene Fields: [New, Patch Available] (was: [Patch Available, New])
Committed revision 740361. Thanks John!
> Adding FilteredDocIdSet and FilteredDocIdSetIterator
> ----------------------------------------------------
>
> Key: LUCENE-1506
> URL: https://issues.apache.org/jira/browse/LUCENE-1506
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.4
> Reporter: John Wang
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: filteredDocidset.txt, filteredDocidset2.txt, LUCENE-1506.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1506) Adding FilteredDocIdSet and
FilteredDocIdSetIterator
Posted by "John Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668668#action_12668668 ]
John Wang commented on LUCENE-1506:
-----------------------------------
sure, will work on that.
> Adding FilteredDocIdSet and FilteredDocIdSetIterator
> ----------------------------------------------------
>
> Key: LUCENE-1506
> URL: https://issues.apache.org/jira/browse/LUCENE-1506
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.4
> Reporter: John Wang
> Assignee: Michael McCandless
> Attachments: filteredDocidset.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Adding 2 convenience classes: FilteredDocIdSet and FilteredDocIDSetIterator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org