You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/12/05 20:50:17 UTC
[GitHub] [commons-pool] garydgregory commented on a change in pull request
#27: NO-JIRA [Javadoc] Add missing @throws comment in PoolUtils.
garydgregory commented on a change in pull request #27: NO-JIRA [Javadoc] Add missing @throws comment in PoolUtils.
URL: https://github.com/apache/commons-pool/pull/27#discussion_r354540090
##########
File path: src/main/java/org/apache/commons/pool2/PoolUtils.java
##########
@@ -307,6 +307,8 @@ public static void checkRethrow(final Throwable t) {
* @param pool
* the ObjectPool to be "wrapped" in a synchronized ObjectPool.
* @param <T> the type of objects in the pool
+ * @throws IllegalArgumentException
+ * when <code>pool</code> is <code>null</code>.
Review comment:
Please use `{@code ...}` instead of HTML tags, it is more succinct and less error prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services