You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/05/18 14:09:36 UTC
[GitHub] [couchdb-config] jiahuili430 opened a new pull request #36: export to_integer, to_boolean for PR#3567
jiahuili430 opened a new pull request #36:
URL: https://github.com/apache/couchdb-config/pull/36
CouchDB 3.x: Move config options from [httpd] to [chttpd] [WIP] #3567
I need to use to_integer() and to_boolean() functions in this PR, which is used in the chttp_util.erl file.
https://github.com/apache/couchdb/pull/3567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] iilyak edited a comment on pull request #36: export to_integer, to_boolean for PR#3567
Posted by GitBox <gi...@apache.org>.
iilyak edited a comment on pull request #36:
URL: https://github.com/apache/couchdb-config/pull/36#issuecomment-843239361
I am curious what people think in regards to porting couch_lib application into 3.x branch? https://github.com/apache/couchdb/commit/94bcb53b16d1729f89031a99cda3295f42801814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] nickva commented on pull request #36: export to_integer, to_boolean for PR#3567
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #36:
URL: https://github.com/apache/couchdb-config/pull/36#issuecomment-843267221
@jiahuili430 Depending on the approach in apache/couchdb#3567 we might not need `to_integer/0` and `to_boolean/0`. If user calls `get_chttpd_config/3` then we use `config:get/3`, and if they call `get_chttp_config_integer/3` we would use `config:get_integer/3`. What do you think?
@iilyak That would be ok. To make it easier to port PRs back and forth we could try to match `main` and `3.x` when reasonable. Libraries and low level utility functions might fall into that category.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] jiahuili430 commented on pull request #36: export to_integer, to_boolean for PR#3567
Posted by GitBox <gi...@apache.org>.
jiahuili430 commented on pull request #36:
URL: https://github.com/apache/couchdb-config/pull/36#issuecomment-843283181
@iilyak @nickva Thanks for the review. I will use `config:get_integer/3` instead of `config:get/3` for the `get_chttpd_config_integer/3`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] iilyak commented on pull request #36: export to_integer, to_boolean for PR#3567
Posted by GitBox <gi...@apache.org>.
iilyak commented on pull request #36:
URL: https://github.com/apache/couchdb-config/pull/36#issuecomment-843239361
I am curious what people think in regards to porting couch_lib application into 3.x branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] jiahuili430 closed pull request #36: export to_integer, to_boolean for PR#3567
Posted by GitBox <gi...@apache.org>.
jiahuili430 closed pull request #36:
URL: https://github.com/apache/couchdb-config/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org