[GitHub] [helix] dasahcc commented on a change in pull request #883: Support enableCompression in workflow and job configs

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #883: Support enableCompression in workflow and job configs
URL: https://github.com/apache/helix/pull/883#discussion_r391763665
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/task/JobConfig.java
 ##########
 @@ -553,8 +556,11 @@ public static Builder fromMap(Map<String, String> cfg) {
       }
       if (cfg.containsKey(JobConfigProperty.RebalanceRunningTask.name())) {
         b.setRebalanceRunningTask(
-            Boolean.valueOf(cfg.get(JobConfigProperty.RebalanceRunningTask.name())));
+            Boolean.parseBoolean(cfg.get(JobConfigProperty.RebalanceRunningTask.name())));
       }
+      // If not set, parseBoolean returns false for null
+      b.setEnableCompression(
 
 Review comment:
   Then we should do a check here, right? If get null, we will get exception for parse boolean.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org