You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/05/29 23:02:41 UTC

[GitHub] [systemds] mboehm7 commented on pull request #1284: [SYSTEMDS-2978] Federated frame tokenize

mboehm7 commented on pull request #1284:
URL: https://github.com/apache/systemds/pull/1284#issuecomment-850911151


   LGTM - thanks for the patch @OlgaOvcharenko. During the merge, I cleaned up some surrounding redundancy, and fixed two minor things in the tokenization (exception handling, unnecessary symbol table changes at coordinator).
   
   Furthermore, note that JSON does not need double quotes around attribute names, so we can avoid the escaping `\"attribute\":value` at DML script level.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org