You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/19 21:35:13 UTC

[GitHub] [airflow] natanweinberger edited a comment on pull request #15425: Fix CLI connections import

natanweinberger edited a comment on pull request #15425:
URL: https://github.com/apache/airflow/pull/15425#issuecomment-822800538


   I've refactored the functionality that reads data from a file and creates connections from it.
   
   - the helper functions to parse the contents of JSON, YAML and env files are moved from `airflow/secrets/local_filesystem.py` to `airflow/utils/parse.py`, as suggested by @mik-laj above
   - there is a new method `Connection.from_dict`
   - the connections import CLI function uses the parse utils and `Connection.from_dict` to import connections from a file
   
   I was as conservative as possible in refactoring the secrets backend in this PR, but it seems like there's not much that uses it. I'd be open to doing some broader clean up there as a follow-up PR.
   
   @mik-laj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org