You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "Brijesh619 (via GitHub)" <gi...@apache.org> on 2026/09/03 18:14:25 UTC

Re: [PR] ATLAS-5376: Atlas UI: Relationship cards layout breaking, overlapping, and tooltip placement issues with long entity names (React & Classic UI) [atlas]

Brijesh619 commented on code in PR #737:
URL: https://github.com/apache/atlas/pull/737#discussion_r3927376431


##########
dashboard/src/views/DetailPage/EntityDetailTabs/RelationshipLineage.tsx:
##########
@@ -48,28 +48,40 @@ import { CloseIcon, LightTooltip } from "@components/muiComponents";
 import { useAppSelector } from "@hooks/reducerHook";
 import { Link as MUILink } from "@mui/material";
 
+interface CustomLinkProps {
+  href: string;
+  status: string;
+  guid: string;

Review Comment:
   I've updated CustomLink in RelationshipLineage.tsx to utilize guid by adding data-guid={guid} on the <li> element and data-testid={relationship-link-${guid}} on MUILink for better testability and DOM querying



##########
dashboardv2/public/css/scss/theme.scss:
##########
@@ -536,7 +537,8 @@ hr[size="10"] {
 }
 
 .tooltip-inner {
-    max-width: none;
+    max-width: 300px;

Review Comment:
   I've restored .tooltip-inner { max-width: none; } in theme.scss to prevent any unexpected wrapping regressions across other Classic UI tooltips.
   
   I've scoped .tooltip-inner { max-width: 300px; } specifically within relationship views (.relationship-box, .relationship-node-details, .relationship-cards-container, .box-panel) in relationship.scss.



##########
dashboardv2/public/js/views/graph/RelationshipLayoutView.js:
##########
@@ -152,14 +152,14 @@ define([
                 }
                 return { nodes: nodes, links: links };
             },
-            onRender: function() {
+            onRender: function () {

Review Comment:
    I've reverted the formatting-only whitespace diffs in RelationshipLayoutView.js to match the existing codebase style. The diff now strictly highlights only the functional code changes.



##########
dashboardv2/public/css/scss/theme.scss:
##########
@@ -536,7 +537,8 @@ hr[size="10"] {
 }
 
 .tooltip-inner {
-    max-width: none;
+    max-width: 300px;
+    word-wrap: break-word;

Review Comment:
   I've updated .tooltip-inner in theme.scss to include overflow-wrap: break-word.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org