[GitHub] [shardingsphere] abhinav-koppula commented on a diff in pull request #20801: [Issue #20376]-Improved coverage of DropTableStatementHandler

[GitBox <gi...@apache.org>]

abhinav-koppula commented on code in PR #20801:
URL: https://github.com/apache/shardingsphere/pull/20801#discussion_r962795307


##########
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/DropTableStatementHandlerTest.java:
##########
@@ -30,42 +31,52 @@
 public final class DropTableStatementHandlerTest {
     
     @Test
-    public void assertContainsIfExistsForMySQL() {
+    public void assertIfExistsForMySQL() {
         assertTrue(DropTableStatementHandler.ifExists(new MySQLDropTableStatement(true)));
+        assertFalse(DropTableStatementHandler.ifExists(new MySQLDropTableStatement(false)));
     }
     
     @Test
-    public void assertContainsIfExistsForPostgreSQL() {
+    public void assertIfExistsForPostgreSQL() {
         assertTrue(DropTableStatementHandler.ifExists(new PostgreSQLDropTableStatement(true, false)));
+        assertFalse(DropTableStatementHandler.ifExists(new PostgreSQLDropTableStatement(false, false)));
     }
     
     @Test
-    public void assertContainsIfExistsForSQLServer() {
+    public void assertIfExistsForSQLServer() {
         assertTrue(DropTableStatementHandler.ifExists(new SQLServerDropTableStatement(true)));
+        assertFalse(DropTableStatementHandler.ifExists(new SQLServerDropTableStatement(false)));
     }
-    

Review Comment:
   Thanks, fixed it here - https://github.com/apache/shardingsphere/pull/20801/commits/614a7f6e17f68474c718cdc54b93ac8ef733abf9.
   From now onwards, I shall run this before submitting a PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org