You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/29 04:51:29 UTC
[GitHub] [flink] cuibo01 opened a new pull request #16315: FLINK-23174 Log improvement in Task throws Error
cuibo01 opened a new pull request #16315:
URL: https://github.com/apache/flink/pull/16315
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-870249808
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eafd3f43b41725f250ba8b6c704581b283bb23cc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19657",
"triggerID" : "eafd3f43b41725f250ba8b6c704581b283bb23cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eafd3f43b41725f250ba8b6c704581b283bb23cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19657)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur edited a comment on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
curcur edited a comment on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-881322557
After reading the PR, I think it aims for two sets of log enhancements. Please correct me if I misunderstand:
1. Add stack trace of thread dump in some places.
Would you mind sharing a bit of what extra info is exposed with these stack traces? The calling stack seems to be able to be tracked through function calls; Also, I think the most important info should already be included in the `throwable error` stack trace". The `throwable error` stack will be printed when the error is handled. If it is not, we probably should understand why and fix it there.
2. log remote channel address in `notifyAllChannelsOfErrorAndClose` (I do not think other added logging in this method provides any more msg, reason same as point 1)
To my best knowledge, if an error is due to a remote error (sender side or network), it will be wrapped as a `RemoteTransportException` which has already included remote socket address; otherwise, the error can be any type of Throwable,
which I think should be enough in most cases.
But if you think we should log remote socket address in all cases, we can wrap to different types of Exceptions (like ChannelException, and including the remote address and local address in it). That's the simplest way I can think of without violating and polluting existing logs.
Please let me know what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-870249808
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eafd3f43b41725f250ba8b6c704581b283bb23cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "eafd3f43b41725f250ba8b6c704581b283bb23cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eafd3f43b41725f250ba8b6c704581b283bb23cc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-881322557
After reading the PR, I think it aims for two sets of log enhancements. Please correct me if I misunderstand:
1. Add stack trace of thread dump in some places.
Would you mind sharing a bit of what extra info is exposed with these stack traces? The calling stack seems to be able to be tracked through function calls; Also, I think the most important info should already be included in the `throwable error` stack trace". The `throwable error` stack will be printed when the error is handled. If it is not, we probably should understand why and fix it there.
2. log remote channel address in `notifyAllChannelsOfErrorAndClose` (I do not think other added logging in this method provides any more msg, reason same as point 1)
To my best knowledge, if an error is due to a remote error (sender side or network), it will be wrapped as a `RemoteTransportException` which will include remote socket address; otherwise, the error can be any type of Throwable,
which I think should be enough in most cases.
But if you think we should log remote socket address in all cases, we can wrap to different types of Exceptions (like ChannelException, and including the remote address and local address in it). That's the simplest way I can think of without violating and polluting existing logs.
Please let me know what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-870249808
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eafd3f43b41725f250ba8b6c704581b283bb23cc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19657",
"triggerID" : "eafd3f43b41725f250ba8b6c704581b283bb23cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eafd3f43b41725f250ba8b6c704581b283bb23cc Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19657)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-870238926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #16315:
URL: https://github.com/apache/flink/pull/16315#discussion_r663092289
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -243,8 +245,32 @@ public void channelWritabilityChanged(ChannelHandlerContext ctx) throws Exceptio
writeAndFlushNextMessageIfPossible(ctx.channel());
}
+ private void printLogError(Throwable cause, StackTraceElement[] stackTraceElements) {
+ SocketAddress remoteAddr = null;
+ SocketAddress localAddr = null;
+ if (ctx != null) {
+ remoteAddr = ctx.channel().remoteAddress();
+ localAddr = ctx.channel().localAddress();
+ }
+ LOG.error(
+ "A remote channel of {} to {} throws a exception. and all {} will be notified and"
+ + " set error.",
+ localAddr == null ? "localAddr" : localAddr,
+ remoteAddr == null ? "remoteAddr" : remoteAddr,
+ String.join(
+ ",",
+ inputChannels.values().stream()
+ .map(RemoteInputChannel::toString)
+ .collect(Collectors.toList())),
+ cause);
+ LOG.error(
+ "A remote channel throws exception.",
+ LogStackUtils.getCallStack(stackTraceElements));
+ }
Review comment:
I don't think that we should log this information on error log level because it is perfectly normal that a remote connection can fail (e.g. if the `TaskExecutor` dies).
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1451,6 +1452,9 @@ private boolean transitionState(
targetState,
getLocationInformation(),
error);
+ LOG.warn(
+ "Print Execution {}",
+ LogStackUtils.getCallStack(Thread.currentThread().getStackTrace()));
Review comment:
I don't think that this will add a lot of extra information.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java
##########
@@ -1038,7 +1039,11 @@ private boolean transitionState(JobStatus current, JobStatus newState, Throwable
current,
newState,
error);
-
+ if (error != null) {
+ LOG.warn(
+ "Print ExecutionGraph {}",
+ LogStackUtils.getCallStack(Thread.currentThread().getStackTrace()));
+ }
Review comment:
It should always be the main thread of the `JobMaster` that calls the `transitionState` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cuibo01 commented on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-871018807
hi @zentol @dawidwys @pnowojski @rkhachatryan @zhuzhurk @tillrohrmann @rmetzger @becketqin can you review the PR, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cuibo01 commented on a change in pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on a change in pull request #16315:
URL: https://github.com/apache/flink/pull/16315#discussion_r663780810
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java
##########
@@ -1038,7 +1039,11 @@ private boolean transitionState(JobStatus current, JobStatus newState, Throwable
current,
newState,
error);
-
+ if (error != null) {
+ LOG.warn(
+ "Print ExecutionGraph {}",
+ LogStackUtils.getCallStack(Thread.currentThread().getStackTrace()));
+ }
Review comment:
from the log, we can see the scene where some exception occurred.
i think the PR helps to analyze some exceptions and is especially important for newcomers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-870238926
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit eafd3f43b41725f250ba8b6c704581b283bb23cc (Tue Dec 14 09:06:10 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-870249808
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eafd3f43b41725f250ba8b6c704581b283bb23cc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19657",
"triggerID" : "eafd3f43b41725f250ba8b6c704581b283bb23cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eafd3f43b41725f250ba8b6c704581b283bb23cc Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19657)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cuibo01 commented on a change in pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on a change in pull request #16315:
URL: https://github.com/apache/flink/pull/16315#discussion_r663783375
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -243,8 +245,32 @@ public void channelWritabilityChanged(ChannelHandlerContext ctx) throws Exceptio
writeAndFlushNextMessageIfPossible(ctx.channel());
}
+ private void printLogError(Throwable cause, StackTraceElement[] stackTraceElements) {
+ SocketAddress remoteAddr = null;
+ SocketAddress localAddr = null;
+ if (ctx != null) {
+ remoteAddr = ctx.channel().remoteAddress();
+ localAddr = ctx.channel().localAddress();
+ }
+ LOG.error(
+ "A remote channel of {} to {} throws a exception. and all {} will be notified and"
+ + " set error.",
+ localAddr == null ? "localAddr" : localAddr,
+ remoteAddr == null ? "remoteAddr" : remoteAddr,
+ String.join(
+ ",",
+ inputChannels.values().stream()
+ .map(RemoteInputChannel::toString)
+ .collect(Collectors.toList())),
+ cause);
+ LOG.error(
+ "A remote channel throws exception.",
+ LogStackUtils.getCallStack(stackTraceElements));
+ }
Review comment:
if TaskExecutor dies, the log is not important, and in this scenario, the log has little effect.
but if the Task fails due to network jitter, I think the log is important. Based on the log, we can know which remote channel are abnormal and which inputChannels fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur edited a comment on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
curcur edited a comment on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-881322557
After reading the PR, I think it aims for two sets of log enhancements. Please correct me if I misunderstand:
1. Add stack trace of thread dump in some places.
Would you mind sharing a bit of what extra info is exposed with these stack traces? The calling stack seems to be able to be tracked through function calls; Also, I think the most important info should already be included in the `throwable error` stack trace". The `throwable error` stack will be printed when the error is handled. If it is not, we probably should understand why and fix it there.
2. log remote channel address in `notifyAllChannelsOfErrorAndClose` (I do not think other added logging in this method provides any more msg, reason same as point 1)
To my best knowledge, if an error is due to a remote error (sender side or network), it will be wrapped as a `RemoteTransportException` which has already included remote socket address; otherwise, the error can be any type of Throwable,
which I think should be enough in most cases.
But if you really think we should log remote socket address in all cases, we can wrap to a unified type of Exceptions (like ChannelException, and including the remote address and local address in it). That's the simplest way I can think of without violating and polluting existing logs.
Please let me know what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-870249808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cuibo01 commented on a change in pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on a change in pull request #16315:
URL: https://github.com/apache/flink/pull/16315#discussion_r663780810
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java
##########
@@ -1038,7 +1039,11 @@ private boolean transitionState(JobStatus current, JobStatus newState, Throwable
current,
newState,
error);
-
+ if (error != null) {
+ LOG.warn(
+ "Print ExecutionGraph {}",
+ LogStackUtils.getCallStack(Thread.currentThread().getStackTrace()));
+ }
Review comment:
from the log, we can see the scene where some exception occurred.
i think the PR helps to analyze some exceptions and is especially important for newcomers.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -243,8 +245,32 @@ public void channelWritabilityChanged(ChannelHandlerContext ctx) throws Exceptio
writeAndFlushNextMessageIfPossible(ctx.channel());
}
+ private void printLogError(Throwable cause, StackTraceElement[] stackTraceElements) {
+ SocketAddress remoteAddr = null;
+ SocketAddress localAddr = null;
+ if (ctx != null) {
+ remoteAddr = ctx.channel().remoteAddress();
+ localAddr = ctx.channel().localAddress();
+ }
+ LOG.error(
+ "A remote channel of {} to {} throws a exception. and all {} will be notified and"
+ + " set error.",
+ localAddr == null ? "localAddr" : localAddr,
+ remoteAddr == null ? "remoteAddr" : remoteAddr,
+ String.join(
+ ",",
+ inputChannels.values().stream()
+ .map(RemoteInputChannel::toString)
+ .collect(Collectors.toList())),
+ cause);
+ LOG.error(
+ "A remote channel throws exception.",
+ LogStackUtils.getCallStack(stackTraceElements));
+ }
Review comment:
if TaskExecutor dies, the log is not important, and in this scenario, the log has little effect.
but if the Task fails due to network jitter, I think the log is important. Based on the log, we can know which remote channel are abnormal and which inputChannels fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16315: FLINK-23174 Log improvement in Task throws Error
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16315:
URL: https://github.com/apache/flink/pull/16315#issuecomment-870238926
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit eafd3f43b41725f250ba8b6c704581b283bb23cc (Tue Jun 29 05:06:49 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-23174).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org