You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/28 15:39:49 UTC
[GitHub] [arrow-rs] flisky opened a new pull request, #2209: parquet: export json api with `serde_json` feature name
flisky opened a new pull request, #2209:
URL: https://github.com/apache/arrow-rs/pull/2209
# Rationale for this change
I'm trying to read parquet file without `arrow` dependency, for the sake of smaller binary size. However, `parquet::record::Row#to_json_value` is gated with `cli` feature flag, which introduces other unnecessary crates.
# What changes are included in this PR?
Replace `feature = cli` with `feature = serde_json`.
# Are there any user-facing changes?
No. `serde_json` is already covered by `cli`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2209: parquet: export json api with `serde_json` feature name
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2209:
URL: https://github.com/apache/arrow-rs/pull/2209#issuecomment-1198903196
Thank you for this, would it be possible to instead introduce a top-level "json" feature, as opposed to piggybacking off the optional crates feature. This will be a better UX for users, and future proof it we ever moved to a different JSON implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2209: parquet: export json api with `serde_json` feature name
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2209:
URL: https://github.com/apache/arrow-rs/pull/2209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2209: parquet: export json api with `serde_json` feature name
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2209:
URL: https://github.com/apache/arrow-rs/pull/2209#issuecomment-1199156904
Benchmark runs are scheduled for baseline = 3505afad180f96df488c8b67c6dadc9e6239ce62 and contender = 588f40889f5970de66cce855e71a65fc098a4691. 588f40889f5970de66cce855e71a65fc098a4691 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c9bb6a245a244388b355f5d8053fa10f...e300572697904e009f1d224e05d9b346/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1129f381365c44d5b490b7c65b9722b1...5d8cbe28b9144976951988a724e424a7/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/485a13b5a2374dba97bc15de8fafe5fa...3864424795fb4fcbaa273658c15be41d/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c09b46980b9046abbd69fe6e7142d88c...2dbfb7a318f54ca99de6a5ab10343e9b/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2209: parquet: export json api with `serde_json` feature name
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2209:
URL: https://github.com/apache/arrow-rs/pull/2209#issuecomment-1198986303
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2209](https://codecov.io/gh/apache/arrow-rs/pull/2209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa1fb6d) into [master](https://codecov.io/gh/apache/arrow-rs/commit/bc493d92c2a032a95d92dab81642f05182f20d81?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc493d9) will **decrease** coverage by `0.04%`.
> The diff coverage is `31.11%`.
> :exclamation: Current head aa1fb6d differs from pull request most recent head f0c0dfe. Consider uploading reports for the commit f0c0dfe to get more accurate results
```diff
@@ Coverage Diff @@
## master #2209 +/- ##
==========================================
- Coverage 82.56% 82.52% -0.05%
==========================================
Files 239 239
Lines 62269 62304 +35
==========================================
+ Hits 51415 51417 +2
- Misses 10854 10887 +33
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow-flight/examples/flight\_sql\_server.rs](https://codecov.io/gh/apache/arrow-rs/pull/2209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3ctZmxpZ2h0L2V4YW1wbGVzL2ZsaWdodF9zcWxfc2VydmVyLnJz) | `0.00% <0.00%> (ø)` | |
| [arrow-flight/src/sql/server.rs](https://codecov.io/gh/apache/arrow-rs/pull/2209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3ctZmxpZ2h0L3NyYy9zcWwvc2VydmVyLnJz) | `0.00% <0.00%> (ø)` | |
| [parquet/src/record/api.rs](https://codecov.io/gh/apache/arrow-rs/pull/2209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvcmVjb3JkL2FwaS5ycw==) | `96.82% <ø> (ø)` | |
| [.../src/array/builder/primitive\_dictionary\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvcHJpbWl0aXZlX2RpY3Rpb25hcnlfYnVpbGRlci5ycw==) | `80.30% <100.00%> (+1.61%)` | :arrow_up: |
| [...rquet/src/arrow/record\_reader/definition\_levels.rs](https://codecov.io/gh/apache/arrow-rs/pull/2209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvcmVjb3JkX3JlYWRlci9kZWZpbml0aW9uX2xldmVscy5ycw==) | `87.34% <0.00%> (-1.27%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.75% <0.00%> (-0.23%)` | :arrow_down: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/2209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.62% <0.00%> (+0.19%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2209: parquet: export json api with `serde_json` feature name
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2209:
URL: https://github.com/apache/arrow-rs/pull/2209#issuecomment-1198446485
Thanks @flisky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org