[jira] [Commented] (KAFKA-822) Reassignment of partitions needs a cleanup

["Swapnil Ghike (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612355#comment-13612355 ] 

Swapnil Ghike commented on KAFKA-822:
-------------------------------------

Listing additional changes:

6. On the creation of a new partition, NewPartition state change assigns replicas to the partition. Then an OnlineReplica state change adds duplicates to the Seq of assigned replicas. We should change controllerContext.partitionReplicaAssignment to a Set.

                
> Reassignment of partitions needs a cleanup
> ------------------------------------------
>
>                 Key: KAFKA-822
>                 URL: https://issues.apache.org/jira/browse/KAFKA-822
>             Project: Kafka
>          Issue Type: Bug
>          Components: controller, tools
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>              Labels: bugs
>
> 1. This is probably a left-over from when the ReassignPartitionsCommand used to be blocking: 
> Currently, for each partition that is reassigned, controller deletes the /admin/reassign_partitions zk path, and populates it with a new list with the reassigned partition removed from the original list. This is probably an overkill, and we can delete the zk path completely once the reassignment of all partitions has completed successfully or in error. 
> 2. It will help to clarify that there could be no replicas that have started and are not in the ISR when KafkaController.onPartitionReassignment() is called.
> 3. We should batch the requests in KafkaController.StopOldReplicasOfReassignedPartition()
> 4. Update controllerContext.partitionReplicaAssignment only once in KafkaController.updateAssignedReplicasForPartition().
> 5. Need to thoroughly test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira