[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42936: [SPARK-45174][CORE] Support `spark.deploy.maxDrivers`

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #42936:
URL: https://github.com/apache/spark/pull/42936#discussion_r1326839780


##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -844,8 +845,8 @@ private[deploy] class Master(
       // We assign workers to each waiting driver in a round-robin fashion. For each driver, we
       // start from the last worker that was assigned a driver, and continue onwards until we have
       // explored all alive workers.
-      var launched = false
-      var isClusterIdle = true
+      var launched = (drivers.size - waitingDrivers.size) >= maxDrivers

Review Comment:
   No~ `schedule` is re-trigger in many cases and especially on the removal of running drivers. So, if the number of running drivers dropped down, new drivers will be allocated to the slots, @viirya .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org