You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Mykola Nikishov (JIRA)" <ji...@codehaus.org> on 2008/03/11 22:54:28 UTC
[jira] Created: (MINVOKER-25) invoke postBuildHookScript even if
build failed
invoke postBuildHookScript even if build failed
-----------------------------------------------
Key: MINVOKER-25
URL: http://jira.codehaus.org/browse/MINVOKER-25
Project: Maven 2.x Invoker Plugin
Issue Type: Improvement
Affects Versions: 1.2
Reporter: Mykola Nikishov
Priority: Critical
Attachments: 0001-enable-negative-tests.patch
I develop a plugin which is ok to break a build. Current workflow using maven-invoker-plugin looks like:
- if my plug-in works as expected ;-) it breaks an IT build during integration-test phase
- the MojoFailureException is thrown
- the maven-invoker-plugin reports that build failed
- a script defined in postBuildHookScript is never used
As a result I have a false alarm - a broken build when everything is ok. I would like to have an opportunity to decide from a postBuildHookScript whether a build was successful or not.
I've implemented desired functionality and attached a patch against trunk/maven-invoker-plugin@632679.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MINVOKER-25) invoke postBuildHookScript even if
build failed
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINVOKER-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MINVOKER-25:
--------------------------------------
Affects Version/s: (was: 1.2)
1.1
> invoke postBuildHookScript even if build failed
> -----------------------------------------------
>
> Key: MINVOKER-25
> URL: http://jira.codehaus.org/browse/MINVOKER-25
> Project: Maven 2.x Invoker Plugin
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Mykola Nikishov
> Assignee: Benjamin Bentmann
> Priority: Critical
> Fix For: 1.2
>
> Attachments: 0001-enable-negative-tests.patch
>
>
> I develop a plugin which is ok to break a build. Current workflow using maven-invoker-plugin looks like:
> - if my plug-in works as expected ;-) it breaks an IT build during integration-test phase
> - the MojoFailureException is thrown
> - the maven-invoker-plugin reports that build failed
> - a script defined in postBuildHookScript is never used
> As a result I have a false alarm - a broken build when everything is ok. I would like to have an opportunity to decide from a postBuildHookScript whether a build was successful or not.
> I've implemented desired functionality and attached a patch against trunk/maven-invoker-plugin@632679.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MINVOKER-25) invoke postBuildHookScript even if
build failed
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINVOKER-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=132704#action_132704 ]
Benjamin Bentmann commented on MINVOKER-25:
-------------------------------------------
As a workaround you can simply put a {{goals.txt}} into the IT project's base directory and specify the flag "-fn" as a goal, for example:
{noformat}
-fn
package
{noformat}
Not pretty, but makes the IT build pass and calling your post build script for verification.
> invoke postBuildHookScript even if build failed
> -----------------------------------------------
>
> Key: MINVOKER-25
> URL: http://jira.codehaus.org/browse/MINVOKER-25
> Project: Maven 2.x Invoker Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Mykola Nikishov
> Priority: Critical
> Attachments: 0001-enable-negative-tests.patch
>
>
> I develop a plugin which is ok to break a build. Current workflow using maven-invoker-plugin looks like:
> - if my plug-in works as expected ;-) it breaks an IT build during integration-test phase
> - the MojoFailureException is thrown
> - the maven-invoker-plugin reports that build failed
> - a script defined in postBuildHookScript is never used
> As a result I have a false alarm - a broken build when everything is ok. I would like to have an opportunity to decide from a postBuildHookScript whether a build was successful or not.
> I've implemented desired functionality and attached a patch against trunk/maven-invoker-plugin@632679.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MINVOKER-25) invoke postBuildHookScript even if
build failed
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINVOKER-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MINVOKER-25.
-------------------------------------
Assignee: Benjamin Bentmann
Resolution: Fixed
Fix Version/s: 1.2
The additions for MINVOKER-33 introduced a new properties file that allows more control over the invocation settings for a particular IT. The properties interesting for your use case:
{noformat}
# either this way
invoker.buildResult=failure
# or that way
invoker.failureBehavior=fail-never
{noformat}
The setting {{buildResult}} allows to directly assert that the IT project build should fail. If it doesn't, the IT is marked as a failure and the post build script is not executed. If your script should really run always regardless of the IT build result, you need to leave {{buildResult=success}} and use {{failureBehavior=fail-never}} instead.
> invoke postBuildHookScript even if build failed
> -----------------------------------------------
>
> Key: MINVOKER-25
> URL: http://jira.codehaus.org/browse/MINVOKER-25
> Project: Maven 2.x Invoker Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Mykola Nikishov
> Assignee: Benjamin Bentmann
> Priority: Critical
> Fix For: 1.2
>
> Attachments: 0001-enable-negative-tests.patch
>
>
> I develop a plugin which is ok to break a build. Current workflow using maven-invoker-plugin looks like:
> - if my plug-in works as expected ;-) it breaks an IT build during integration-test phase
> - the MojoFailureException is thrown
> - the maven-invoker-plugin reports that build failed
> - a script defined in postBuildHookScript is never used
> As a result I have a false alarm - a broken build when everything is ok. I would like to have an opportunity to decide from a postBuildHookScript whether a build was successful or not.
> I've implemented desired functionality and attached a patch against trunk/maven-invoker-plugin@632679.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira