You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/05 08:24:02 UTC
[jira] [Commented] (FLUME-1181) Context must enforce dot-separated
prefix for sub-properties.
[ https://issues.apache.org/jira/browse/FLUME-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268912#comment-13268912 ]
jiraposter@reviews.apache.org commented on FLUME-1181:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5017/
-----------------------------------------------------------
Review request for Flume, Brock Noland and Hari Shreedharan.
Summary
-------
This change:
* introduces a precondition check in Context.getSubProperties(String prefix) method enforce that the prefix ends with a period,
* fixes the TestPropertiesFileConfigurationProvider to load the property file which was previously not working, and fixes cases that are broken
* refactors some of the source (not all) to externalize the configuration keys into separate constants class
This addresses bug FLUME-1181.
https://issues.apache.org/jira/browse/FLUME-1181
Diffs
-----
/trunk/flume-ng-configuration/src/main/java/org/apache/flume/Context.java 1334310
/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/BasicConfigurationConstants.java PRE-CREATION
/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java 1334310
/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 1334310
/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java 1334310
/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java 1334310
/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 1334310
/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 1334310
/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java PRE-CREATION
/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 1334310
/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 1334310
/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 1334310
/trunk/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1334310
/trunk/flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java 1334310
/trunk/flume-ng-node/src/test/resources/flume-conf.properties 1334310
Diff: https://reviews.apache.org/r/5017/diff
Testing
-------
Ran all tests. The updated TestPropertiesFileConfigurationProvider catches two issues now - the one with channel selector configuration not being set correctly, and the other a similar issue with syslog source format configuration. Both of these issues have been fixed with the changes.
Also done some manual validation of the system with a few simple scenarios.
Thanks,
Arvind
> Context must enforce dot-separated prefix for sub-properties.
> -------------------------------------------------------------
>
> Key: FLUME-1181
> URL: https://issues.apache.org/jira/browse/FLUME-1181
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: v1.2.0
>
> Attachments: FLUME-1181-1.patch
>
>
> Currently the method Context.getSubProperties(String prefix) assumes a well-formed prefix. This can lead to undetected issues such as what is being seen in the current state of channel selector configuration, where the keys within the channel selector are being computed as prefixed with a period.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira