You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/10/22 13:43:26 UTC

[commons-vfs] 01/04: Make some private classes final.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git

commit ae1b2b5f7e63778578541c2ec1b8259d0744de81
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Oct 6 08:14:54 2023 -0400

    Make some private classes final.
---
 .../java/org/apache/commons/vfs2/impl/PrivilegedFileReplicator.java | 6 +++---
 .../org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java    | 2 +-
 .../src/main/java/org/apache/commons/vfs2/tasks/VfsTask.java        | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/PrivilegedFileReplicator.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/PrivilegedFileReplicator.java
index fcfe5e07..b756f768 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/PrivilegedFileReplicator.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/PrivilegedFileReplicator.java
@@ -38,7 +38,7 @@ public class PrivilegedFileReplicator implements FileReplicator, VfsComponent {
     /**
      * An action that closes the wrapped replicator.
      */
-    private class CloseAction implements PrivilegedAction<Object> {
+    private final class CloseAction implements PrivilegedAction<Object> {
         /**
          * Performs the action.
          */
@@ -51,7 +51,7 @@ public class PrivilegedFileReplicator implements FileReplicator, VfsComponent {
     /**
      * An action that initializes the wrapped replicator.
      */
-    private class InitAction implements PrivilegedExceptionAction<Object> {
+    private final class InitAction implements PrivilegedExceptionAction<Object> {
         /**
          * Performs the action.
          */
@@ -65,7 +65,7 @@ public class PrivilegedFileReplicator implements FileReplicator, VfsComponent {
     /**
      * An action that replicates a file using the wrapped replicator.
      */
-    private class ReplicateAction implements PrivilegedExceptionAction<File> {
+    private final class ReplicateAction implements PrivilegedExceptionAction<File> {
         private final FileObject srcFile;
         private final FileSelector selector;
 
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
index 52d8d3cf..8ffa8f91 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
@@ -51,7 +51,7 @@ public final class SftpClientFactory {
     private static final String KEY_STRICT_HOST_KEY_CHECKING = "StrictHostKeyChecking";
 
     /** Interface JSchLogger with JCL. */
-    private static class JSchLogger implements Logger {
+    private static final class JSchLogger implements Logger {
         @Override
         public boolean isEnabled(final int level) {
             switch (level) {
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/tasks/VfsTask.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/tasks/VfsTask.java
index 77aa9780..10f1fb77 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/tasks/VfsTask.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/tasks/VfsTask.java
@@ -34,7 +34,7 @@ public class VfsTask extends Task {
     /**
      * A commons-logging wrapper for Ant logging.
      */
-    private class AntLogger implements Log {
+    private final class AntLogger implements Log {
         @Override
         public void debug(final Object o) {
             log(String.valueOf(o), Project.MSG_DEBUG);
@@ -127,7 +127,7 @@ public class VfsTask extends Task {
     /**
      * Closes the VFS manager when the project finishes.
      */
-    private class CloseListener implements SubBuildListener {
+    private final class CloseListener implements SubBuildListener {
         @Override
         public void buildFinished(final BuildEvent event) {
             closeManager();