You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2018/11/30 18:12:40 UTC

[GitHub] spark pull request #23181: [SPARK-26219][CORE] Executor summary should get u...

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23181#discussion_r237952522
  
    --- Diff: core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala ---
    @@ -1274,47 +1274,69 @@ class AppStatusListenerSuite extends SparkFunSuite with BeforeAndAfter {
       }
     
       test("SPARK-25451: total tasks in the executor summary should match total stage tasks") {
    -    val testConf = conf.clone.set(LIVE_ENTITY_UPDATE_PERIOD, Long.MaxValue)
     
    -    val listener = new AppStatusListener(store, testConf, true)
    +    val isLiveSeq = Seq(true, false)
     
    -    val stage = new StageInfo(1, 0, "stage", 4, Nil, Nil, "details")
    -    listener.onJobStart(SparkListenerJobStart(1, time, Seq(stage), null))
    -    listener.onStageSubmitted(SparkListenerStageSubmitted(stage, new Properties()))
    +    isLiveSeq.foreach { live: Boolean =>
    +      val testConf = if (live) {
    +        conf.clone.set(LIVE_ENTITY_UPDATE_PERIOD, Long.MaxValue)
    --- End diff --
    
    nit: `clone()`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org