You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "hjtran (via GitHub)" <gi...@apache.org> on 2024/03/27 23:20:41 UTC

[I] [Failing Test]: GroupBy example tests (groupby_test.py) fail [beam]

hjtran opened a new issue, #30778:
URL: https://github.com/apache/beam/issues/30778

   ### What happened?
   
   The test utility `assert_that` has to be run in a pipeline that hasn't been executed. Before #30771 it was easy to accidentally do it after a pipeline had already been executed which resulted in a test that would _always_ pass.
   
   After #30771 , it'll no longer be possible to do this. As a result, it turns out groupby_test.py's unit tests are always passing. I've skipped them temporarily
   
   ### Issue Failure
   
   Failure: Test is continually failing
   
   ### Issue Priority
   
   Priority: 2 (backlog / disabled test but we think the product is healthy)
   
   ### Issue Components
   
   - [X] Component: Python SDK
   - [ ] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [ ] Component: IO connector
   - [ ] Component: Beam YAML
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Failing Test]: GroupBy example tests (groupby_test.py) fail [beam]

Posted by "mtauha (via GitHub)" <gi...@apache.org>.
mtauha commented on issue #30778:
URL: https://github.com/apache/beam/issues/30778#issuecomment-3933268861

   I'd like to work on this! Could you assign it to me @hjtran?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Failing Test]: GroupBy example tests (groupby_test.py) fail [beam]

Posted by "mtauha (via GitHub)" <gi...@apache.org>.
mtauha commented on issue #30778:
URL: https://github.com/apache/beam/issues/30778#issuecomment-3933271651

   .take-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Failing Test]: GroupBy example tests (groupby_test.py) fail [beam]

Posted by "alisha-1000 (via GitHub)" <gi...@apache.org>.
alisha-1000 commented on issue #30778:
URL: https://github.com/apache/beam/issues/30778#issuecomment-3830878457

   .take_issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Failing Test]: GroupBy example tests (groupby_test.py) fail [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #30778:
URL: https://github.com/apache/beam/issues/30778#issuecomment-3811120979

   This issue has been marked as stale due to 150 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that’s incorrect or this issue still needs to be addressed, please simply write any comment. If closed, you can reopen the issue at any time. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Failing Test]: GroupBy example tests (groupby_test.py) fail [beam]

Posted by "alisha-1000 (via GitHub)" <gi...@apache.org>.
alisha-1000 commented on issue #30778:
URL: https://github.com/apache/beam/issues/30778#issuecomment-3830874720

   I’m interested in fixing this. I’ll refactor the GroupBy example tests so `assert_that()` is attached before pipeline execution (per #30771) and re-enable the currently skipped tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Failing Test]: GroupBy example tests (groupby_test.py) fail [beam]

Posted by "MansiSingh17 (via GitHub)" <gi...@apache.org>.
MansiSingh17 commented on issue #30778:
URL: https://github.com/apache/beam/issues/30778#issuecomment-3938266158

   @hjtran  I've submitted a fix for this in my PR. Happy to coordinate if there's overlap with @mtauha  work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Failing Test]: GroupBy example tests (groupby_test.py) fail [beam]

Posted by "mtauha (via GitHub)" <gi...@apache.org>.
mtauha commented on issue #30778:
URL: https://github.com/apache/beam/issues/30778#issuecomment-3945713348

   .free-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org