You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/26 10:52:15 UTC

[GitHub] ivankelly commented on issue #577: Clean up internal Bookkeeper constructors

ivankelly commented on issue #577: Clean up internal Bookkeeper constructors
URL: https://github.com/apache/bookkeeper/issues/577#issuecomment-376125719
 
 
   This should be done as part of new api work. Ideally there should be no constructor for the BookKeeper object, but everything should go through a Builder that returns a o.a.b.client.api.BookKeeper object. 
   
   Currently it's not really useful to have o.a.b.client.api.BookKeeper as you have to import o.a.b.client.BookKeeper to create one.
   
   ClientConfiguration should probably be deprecated too, and all the configuration in it put in the builder.
   
   (cc @sijie @eolivelli )

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services