You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/04/25 14:18:53 UTC
[GitHub] brooklyn-server pull request #650: Fix memory leak in BrooklynPersistenceUti...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/650
Fix memory leak in BrooklynPersistenceUtils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix-memory-leak
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/650.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #650
----
commit 6dfb879660328903b6c8f9e4a679b24393893606
Author: Aled Sage <al...@gmail.com>
Date: 2017-04-25T14:18:22Z
Fix memory leak in BrooklynPersistenceUtils
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #650: Fix memory leak in BrooklynPersistenceUtils
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/650
LGTM; testing CatalogYamlRebindTest before this and grepping for
LocalManagementContextForTests in the output of jmap -histo:live
gives an increasing count of contexts over time, which doesn't
seem right:
460: 1 160 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
452: 2 320 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
398: 3 480 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
356: 5 800 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
354: 7 1120 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
335: 9 1440 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
337: 11 1760 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
332: 13 2080 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
323: 16 2560 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
313: 18 2880 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
312: 20 3200 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
283: 23 3680 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
281: 25 4000 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
313: 28 4480 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
269: 30 4800 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
278: 32 5120 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
256: 36 5760 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
262: 37 5920 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
265: 39 6240 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
264: 41 6560 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
262: 44 7040 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
261: 46 7360 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
261: 48 7680 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
254: 50 8000 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
258: 52 8320 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
264: 56 8960 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
239: 58 9280 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
239: 59 9440 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
241: 62 9920 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
235: 64 10240 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
240: 63 10080 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
238: 64 10240 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
with this PR things look better behaved
414: 2 320 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
368: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
374: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
374: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
369: 5 800 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
396: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
395: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
388: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
438: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
365: 6 960 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
369: 6 960 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
396: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
372: 5 800 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
454: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
428: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
387: 5 800 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
387: 5 800 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
405: 5 800 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
403: 5 800 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
400: 5 800 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
416: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
443: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
443: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
390: 5 800 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
389: 6 960 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
409: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
444: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
392: 6 960 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
439: 4 640 org.apache.brooklyn.core.test.entity.LocalManagementContextForTests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #650: Fix memory leak in BrooklynPersistenceUtils
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/650
LGTM merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #650: Fix memory leak in BrooklynPersistenceUti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/650
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---