You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2012/06/20 19:52:42 UTC
[jira] [Created] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Andrew Purtell created HBASE-6245:
-------------------------------------
Summary: Upon page refresh new UI should return to the previously selected tab
Key: HBASE-6245
URL: https://issues.apache.org/jira/browse/HBASE-6245
Project: HBase
Issue Type: Improvement
Affects Versions: 0.96.0
Reporter: Andrew Purtell
Priority: Minor
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6245:
----------------------------------
Component/s: regionserver
master
Tags: noob
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Priority: Minor
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435774#comment-13435774 ]
Elliott Clark commented on HBASE-6245:
--------------------------------------
+1 from me.
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: hbase-6245.patch, hbase-6245-v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell reassigned HBASE-6245:
-------------------------------------
Assignee: Jie Huang
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Assignee: Jie Huang
> Priority: Minor
> Attachments: hbase-6245.patch, hbase-6245-v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436073#comment-13436073 ]
Andrew Purtell commented on HBASE-6245:
---------------------------------------
Thanks Jie and Elliott, I'll commit patch v2.
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: hbase-6245.patch, hbase-6245-v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Jie Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jie Huang updated HBASE-6245:
-----------------------------
Attachment: hbase-6245.patch
It is quite convenient to refresh the page and return that previously selected tab. Here attaches a js solution to keep the previously selected tab while refreshing the page. If it is necessary, we can create a new .js file under hbase-webapps/static/js folder. Any idea, please let me know.
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: hbase-6245.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Jie Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jie Huang updated HBASE-6245:
-----------------------------
Attachment: hbase-6245-v2.patch
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: hbase-6245.patch, hbase-6245-v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell resolved HBASE-6245.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Committed to trunk. Thanks for the patch Jie. Thanks for the review Elliott.
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Assignee: Jie Huang
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: hbase-6245.patch, hbase-6245-v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Jie Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435163#comment-13435163 ]
Jie Huang commented on HBASE-6245:
----------------------------------
Any comment on that patch file?
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: hbase-6245.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Jie Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jie Huang updated HBASE-6245:
-----------------------------
Attachment: hbase-6245-v2.patch
Thank you very much for your suggestions. Here attaches the updated version. More idea, please let me know.
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: hbase-6245.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436340#comment-13436340 ]
Hudson commented on HBASE-6245:
-------------------------------
Integrated in HBase-TRUNK #3228 (See [https://builds.apache.org/job/HBase-TRUNK/3228/])
HBASE-6245. Upon page refresh new UI should return to the previously selected tab (Jie Huang) (Revision 1373983)
Result = FAILURE
apurtell :
Files :
* /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
* /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
* /hbase/trunk/hbase-server/src/main/resources/hbase-webapps/static/js/tab.js
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Assignee: Jie Huang
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: hbase-6245.patch, hbase-6245-v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Jie Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jie Huang updated HBASE-6245:
-----------------------------
Attachment: (was: hbase-6245-v2.patch)
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: hbase-6245.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436435#comment-13436435 ]
Hudson commented on HBASE-6245:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #132 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/132/])
HBASE-6245. Upon page refresh new UI should return to the previously selected tab (Jie Huang) (Revision 1373983)
Result = FAILURE
apurtell :
Files :
* /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
* /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
* /hbase/trunk/hbase-server/src/main/resources/hbase-webapps/static/js/tab.js
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Assignee: Jie Huang
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: hbase-6245.patch, hbase-6245-v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435737#comment-13435737 ]
Elliott Clark commented on HBASE-6245:
--------------------------------------
Lets move the code into a js file. I know it's another http round trip but I think having js code in jamon is a code smell.
Minor Nit:
I've always preferred to not use data-* as a selector maybe ".nav-tabs a" ?
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: hbase-6245.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6245) Upon page refresh new UI should
return to the previously selected tab
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435662#comment-13435662 ]
Andrew Purtell commented on HBASE-6245:
---------------------------------------
I did a bit of manual testing and it seems to work for the singly tabbed case, like the RegionServer. However for multitabbed pages like the Master only the last tab switch is sticky.
It's better than what we have now, I think it could go in as an interim step.
[~eclark] what do you think?
> Upon page refresh new UI should return to the previously selected tab
> ---------------------------------------------------------------------
>
> Key: HBASE-6245
> URL: https://issues.apache.org/jira/browse/HBASE-6245
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Affects Versions: 0.96.0
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: hbase-6245.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira